public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao De Almeida Pereira <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3129] handle encoding issue in File manager
Date: Thu, 01 Mar 2018 22:11:28 +0000
Message-ID: <CAE+jjamODcpfm7NpCJ3_L1SFKbbRf2KPb30OL6NKYhqDyX_50A@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZRGrSBp_tLhZnOBsq9EdMYsb7B+2itYkQw0-pEeHfxf2Q@mail.gmail.com>
References: <CAKKotZQcXpEZDWOfM9DKU2n7v6RQBUpZTuNiXe7cZaCTW1Yi-w@mail.gmail.com>
	<CAE+jjanCUch3F265Q=izKARKah-gka1cAmvZGFWQ7UgNFYHmbw@mail.gmail.com>
	<CAKKotZRGrSBp_tLhZnOBsq9EdMYsb7B+2itYkQw0-pEeHfxf2Q@mail.gmail.com>

Hello Joao,
The pipeline is green and I believe the change is good to be merged.

Thanks
Joao

On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala <
[email protected]> wrote:

> Thanks Joao for reviewing.
>
> Attaching updated patch fixing PEP8 issues.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hello Murtuza,
>>
>> The code looks pretty good, love the fact that you extracted it so that
>> our file size stop growing and get more manageable. All tests pass on our
>> CI.
>>
>> The only issue I found was linting:
>>
>> pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/
>> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:12: [E302] expected
>> 2 blank lines, found 1
>> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:53: [W391] blank
>> line at end of file
>> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:27:
>> [E121] continuation line under-indented for hanging indent
>> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:29:
>> [E122] continuation line missing indentation or outdented
>> 1       E121 continuation line under-indented for hanging indent
>> 1       E122 continuation line missing indentation or outdented
>> 1       E302 expected 2 blank lines, found 1
>> 1       W391 blank line at end of file
>> 4
>>
>> When this is fixed I think we are good to go
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 1, 2018 at 3:01 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where user was not able to open the file with
>>> non utf-8 encoding.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3129] handle encoding issue in File manager
  In-Reply-To: <CAE+jjamODcpfm7NpCJ3_L1SFKbbRf2KPb30OL6NKYhqDyX_50A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox