public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao De Almeida Pereira <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
Date: Tue, 06 Mar 2018 16:06:25 +0000
Message-ID: <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
References: <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>

Hi Murtuza,

The code change works, and I passed the patches through our pipeline and
everything is green.
Personally I would love this bug fixes to have refactored the function into
smaller chunk and made it more readable so that the next time someone need
to check out a problem in the same area it is easier. I understand that
without a good test coverage it is hard to have confidence while
refactoring, but we need to start somewhere.

@Hackers
Here is a video that I saw some time ago about refactoring existing code
and code complexity that is very interesting
https://www.youtube.com/watch?v=8bZh5LMaSmE
In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsConf
2014, and with it tries to demonstrate that code can be refactored and with
that it make the code much more simpler. But the journey is not always
simple and the complexity will increase before it get simpler. It is a good
example of something that we can try with our code.


Thanks
Joao

On Tue, Mar 6, 2018 at 4:23 AM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA patch to fix the issue in Table node where wrong sql was generated
> while altering column.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
  In-Reply-To: <CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox