public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
Date: Fri, 9 Mar 2018 15:23:59 +0000
Message-ID: <CA+OCxoyr_Gmm3W0DyK-jNjLS9pjnb1H_0yTi+F4-M9WncgSmEg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZR0X-oK1noPYbDaxH2PF0RWj=5wmNUavmRxX8KUH-ZBkw@mail.gmail.com>
References: <CAKKotZSRSKPWzapTT6fJQiCAprRs_h644mXkeP_ba-NbynJufg@mail.gmail.com>
<CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com>
<CA+OCxox3gREiVKvXSh2=OjooseZH3cveT90C97k6mH6s0AYGnA@mail.gmail.com>
<CAKKotZRwaG6X-9ZZ3+CCMQ0y=h7kTR_ver=QfWf6savrjtbF3A@mail.gmail.com>
<CAKKotZSas8Chx0neZqpvFwSBPE1JDwF=afbvP3aptfF578Xhxw@mail.gmail.com>
<CA+OCxoywkaEX7VL-4G_p=DeLAFyWmSAOGGd+JOMNQ-bew1_eMg@mail.gmail.com>
<CAKKotZRjFMY1SmPJQqT_9+iV0__C86S0gHqdj1MGAtDN3SiVGw@mail.gmail.com>
<CA+OCxowwF4EV+2Cqz7ayx54PtSiccu7zUTw9RABaZDSO3t_m6w@mail.gmail.com>
<CAKKotZR-nWOFoGSg02Q51ohVH6SX6eSthYEwy+N8i4sexLFbVA@mail.gmail.com>
<CAE+jjakFWNBEW17HLWYq4B6zXDnqKag0erccK2POh0_WiLeGSg@mail.gmail.com>
<CAKKotZR0X-oK1noPYbDaxH2PF0RWj=5wmNUavmRxX8KUH-ZBkw@mail.gmail.com>
Thanks, patch applied.
On Thu, Mar 8, 2018 at 6:00 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Thank you Joao
>
> Regards,
> Murtuza
>
>
> On Thu, Mar 8, 2018 at 10:19 PM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hello Murtuza/Dave,
>>
>> Nice splitting of some of the functionality into functions, removing some
>> of the complexity of the initial function. Good job.
>>
>> I made some changes because the linter was failing and also changed some
>> variable names.
>> These changes pass our CI and the linter.
>>
>> Thanks
>> Joao
>>
>> On Thu, Mar 8, 2018 at 8:13 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Please find updated patch.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Thu, Mar 8, 2018 at 6:10 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Can you rebase this please?
>>>>
>>>> Thanks.
>>>>
>>>> On Thu, Mar 8, 2018 at 9:00 AM, Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Please find updated patch & updated test case to cover that as well.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Wed, Mar 7, 2018 at 9:59 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Wed, Mar 7, 2018 at 2:59 PM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> PFA updated patch.
>>>>>>>
>>>>>>>
>>>>>> Using your example on the ticket, I added a "character varying (32)"
>>>>>> column with NOT NULL to the table. When I then edit the column, and turn
>>>>>> off NOT NULL (making no other changes), the SQL generated is:
>>>>>>
>>>>>> ALTER TABLE public.test_drop
>>>>>> ALTER COLUMN col2 TYPE character varying (32) COLLATE
>>>>>> pg_catalog."default";
>>>>>> ALTER TABLE public.test_drop
>>>>>> ALTER COLUMN col2 DROP NOT NULL;
>>>>>>
>>>>>> I didn't see that when turning off NOT NULL for col1.
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (12+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM#2989] To fix the issue in Table node
In-Reply-To: <CA+OCxoyr_Gmm3W0DyK-jNjLS9pjnb1H_0yTi+F4-M9WncgSmEg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox