public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joao De Almeida Pereira <[email protected]>
To: Dave Page <[email protected]>
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an
Date: Tue, 13 Mar 2018 20:54:19 +0000
Message-ID: <CAE+jjamkhcVD-ibzQr+H3vLg3QDjAsb2tqw6r2edvhyYnePstw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi Dave, Khushboo
Looks like there is a linting issue with this commit:
Successfully installed pycodestyle-2.3.1
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
/tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace
around operator
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2)
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
1 E225 missing whitespace around operator
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
1 E303 too many blank lines (2)
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
2
Best Regards,
Victoria & Joao
On Tue, Mar 13, 2018 at 4:45 PM Dave Page <[email protected]> wrote:
> Fix unicode handling in the external process tools and show the complete
> command in the process viewer. Fixes #2963. Fixes #3157.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a...
> Author: Khushboo Vashi <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/misc/bgprocess/processes.py | 36
> +++++++++++++++++++++--
> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
> web/pgadmin/tools/backup/__init__.py | 5 ++--
> 3 files changed, 38 insertions(+), 9 deletions(-)
>
>
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an
In-Reply-To: <CAE+jjamkhcVD-ibzQr+H3vLg3QDjAsb2tqw6r2edvhyYnePstw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox