public inbox for [email protected]
help / color / mirror / Atom feedFrom: Joao De Almeida Pereira <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
Date: Wed, 28 Mar 2018 13:21:45 +0000
Message-ID: <CAE+jjan=7VLF8RXJ1N+5mt1sC26nXm6bvbsg-=p4g0FJc+fWKA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfctsa8gLahMW7azew-JgkVbzEkyZj=jBkPAyMH92=yvg@mail.gmail.com>
References: <CANxoLDfycf2jb4=Jsx35w3W_SLrYOSakPG7wZ2cduwPmK5oEBQ@mail.gmail.com>
<CA+OCxoyir44UeMMM-=MG47wbWQN7+A09FMcxkjob0-9y0M7LDg@mail.gmail.com>
<CAE+jjak+_Ny7GOwpebvQZJuXorzw36NQn7mqPYUMm3xx34=+SA@mail.gmail.com>
<CANxoLDcokPKXM+Ga0uSYz-TeqzreSrcxYBHfZ_j6nG7TuoeHnw@mail.gmail.com>
<CAE+jja=DJCmag+N_5+p9=HKFL+HjYOT9QnyxQORV_a175W_22Q@mail.gmail.com>
<CANxoLDfctsa8gLahMW7azew-JgkVbzEkyZj=jBkPAyMH92=yvg@mail.gmail.com>
Hi Akshay,
Thanks for the clarification, looks like there isn't much we can do then
Best Regards,
Joao
On Wed, Mar 28, 2018 at 1:35 AM Akshay Joshi <[email protected]>
wrote:
> Hi Joao
>
> On Tue, Mar 27, 2018 at 6:53 PM, Joao De Almeida Pereira <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> We were not trying to imply that your fix did not solve the problem, we
>> were trying to understand the root cause of the problem.
>>
>
> As per my understanding root cause of the problem is "exception_obj.
> diag.severity" variable was not decoded and used directly, when I debug
> the code that variable contains the encoded string, so I have just use the
> function "*self.decode_to_utf8()*" and it works. If you can see the code
> below to this fix will have all the variables decoded to utf8.
>
>>
>> 1. We were not able to reproduce the problem
>> We followed your directions in RM, removed your fix but we could not
>> reproduce the problem. So we could not make sure that the application is in
>> fact working. This maybe have been because we missed something.
>> 2. The fix does not tackle the big problem
>> From what we read on the RM the big problem is "when we throw an
>> exception the front end is displaying the query successful message". Did
>> you also understood that from the RM?
>>
> We believe this is the real problem behind the RM.
>> Were you able replicate this behavior? If so we need to address the root
>> of this.
>>
>
> Yes I understood that from RM, but as I mentioned in my previous email
> that I haven't encounter that problem while trying to reproduce this. I got
> "*Not connected to the server*..." error not the "Query returned
> successfully". This bug has been log 2 months ago, I am not sure but it may
> possible that we have fixed/change some logic because of that I have seen
> "Not connected to the server......" error instead of "Query returned
> successfully".
>
>>
>>
>> As an aside sniping bugs is fine in some situations but as a general rule
>> of thumb is a bad approach and creates a blob of code that no one can
>> manage. A situation like this look like a very promising candidate for
>> extraction/refactoring in our point of view. In which situation do you
>> normally refactor or extract code?
>>
>> Thanks
>> Joao
>>
>>
>> On Tue, Mar 27, 2018, 1:31 AM Akshay Joshi <[email protected]>
>> wrote:
>>
>>> Hi Joao
>>>
>>> On Tue, Mar 27, 2018 at 12:01 AM, Joao De Almeida Pereira <
>>> [email protected]> wrote:
>>>
>>>> Hello,
>>>> We tried to reproduce the issue but we were not capable to reproduce
>>>> it.
>>>> What it is strange on the fix is that python is complaining about a
>>>> different line then the one that was fixed. Maybe this is just a Python
>>>> thing....
>>>>
>>>
>>> I have mentioned the steps in RM and I have tried it on Ubuntu 16.
>>> Python is complaining the exact line where I have fixed the logic.
>>>
>>> ex_diag_message = u"{0}: {1}".format(
>>> self.decode_to_utf8(exception_obj.diag.severity), # exception_obj.diag.severity is not decoded before my fix.
>>> self.decode_to_utf8(exception_obj.diag.message_primary)
>>> )
>>>
>>>
>>>
>>>>
>>>> I assume that the fix works, but I would love to see some tests to
>>>> ensure it is working. Another issue that looks more problematic is the fact
>>>> that, as per the Redmine issue, when an exception is thrown it sends back a
>>>> Successful Query message. If this is the case then this fix doesn't look
>>>> like it is enough to solve the problem.
>>>>
>>>
>>> Yes it works. With the latest code I didn't see Successful Query
>>> message, it is showing "Not connected to the server .....", but the stack
>>> trace is same that was mentioned in the RM.
>>>
>>>>
>>>> Thanks
>>>> Victoria & Joao
>>>>
>>>> On Mon, Mar 26, 2018 at 9:00 AM Dave Page <[email protected]> wrote:
>>>>
>>>>> Thanks, applied.
>>>>>
>>>>> On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch to fix RM #3090 pgadmin shows
>>>>>> misleading "Query returned successfully" with incorrect SQL.
>>>>>>
>>>>>> --
>>>>>> *Akshay Joshi*
>>>>>>
>>>>>> *Sr. Software Architect *
>>>>>>
>>>>>>
>>>>>>
>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
In-Reply-To: <CAE+jjan=7VLF8RXJ1N+5mt1sC26nXm6bvbsg-=p4g0FJc+fWKA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox