public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Joao De Almeida Pereira <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
Date: Tue, 27 Mar 2018 11:01:17 +0530
Message-ID: <CANxoLDcokPKXM+Ga0uSYz-TeqzreSrcxYBHfZ_j6nG7TuoeHnw@mail.gmail.com> (raw)
In-Reply-To: <CAE+jjak+_Ny7GOwpebvQZJuXorzw36NQn7mqPYUMm3xx34=+SA@mail.gmail.com>
References: <CANxoLDfycf2jb4=Jsx35w3W_SLrYOSakPG7wZ2cduwPmK5oEBQ@mail.gmail.com>
<CA+OCxoyir44UeMMM-=MG47wbWQN7+A09FMcxkjob0-9y0M7LDg@mail.gmail.com>
<CAE+jjak+_Ny7GOwpebvQZJuXorzw36NQn7mqPYUMm3xx34=+SA@mail.gmail.com>
Hi Joao
On Tue, Mar 27, 2018 at 12:01 AM, Joao De Almeida Pereira <jdealmeidapereira
@pivotal.io> wrote:
> Hello,
> We tried to reproduce the issue but we were not capable to reproduce it.
> What it is strange on the fix is that python is complaining about a
> different line then the one that was fixed. Maybe this is just a Python
> thing....
>
I have mentioned the steps in RM and I have tried it on Ubuntu 16.
Python is complaining the exact line where I have fixed the logic.
ex_diag_message = u"{0}: {1}".format(
self.decode_to_utf8(exception_obj.diag.severity), #
exception_obj.diag.severity is not decoded before my fix.
self.decode_to_utf8(exception_obj.diag.message_primary)
)
>
> I assume that the fix works, but I would love to see some tests to ensure
> it is working. Another issue that looks more problematic is the fact that,
> as per the Redmine issue, when an exception is thrown it sends back a
> Successful Query message. If this is the case then this fix doesn't look
> like it is enough to solve the problem.
>
Yes it works. With the latest code I didn't see Successful Query
message, it is showing "Not connected to the server .....", but the stack
trace is same that was mentioned in the RM.
>
> Thanks
> Victoria & Joao
>
> On Mon, Mar 26, 2018 at 9:00 AM Dave Page <[email protected]> wrote:
>
>> Thanks, applied.
>>
>> On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch to fix RM #3090 pgadmin shows misleading
>>> "Query returned successfully" with incorrect SQL.
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>> 976-788-8246 <+91%2097678%2088246>*
>>>
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL
In-Reply-To: <CANxoLDcokPKXM+Ga0uSYz-TeqzreSrcxYBHfZ_j6nG7TuoeHnw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox