public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507
Date: Wed, 7 Mar 2018 21:43:08 +0530
Message-ID: <CAFOhELc+=eod5gtxQvRw=G2t=BQWb=2SgHOxbLrA2wxEROutzQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoziegBKj165ysM86fWL3m1CFN5+hnVBDjx3D9eeFHH6=Q@mail.gmail.com>
References: <[email protected]>
<CA+OCxoxrPgB_mv_-50z9d2hj7iHQyeMJGhXtEkGfFMYf4_Ep+w@mail.gmail.com>
<CAFOhELfx_KfUmFc+McR+maHJgLfsi+z+CMfnn3VPgdv539XtuQ@mail.gmail.com>
<CA+OCxoziegBKj165ysM86fWL3m1CFN5+hnVBDjx3D9eeFHH6=Q@mail.gmail.com>
On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <[email protected]> wrote:
>>
>>> Khushboo, can you look at this ASAP please? It passed tests on my
>>> machine, but Jenkins isn't happy.
>>>
>>> I have tried to reproduce the issue with many combination but couldn't
>> reproduce it.
>> With the help of logs, I have tried to fix it. Can you please check this
>> fix is helpful or not?
>>
>
> On my laptop I now get:
>
> ======================================================================
> ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.
> TestPollQueryTool)
> When query tool polling returns messages with result data-set
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/
> tests/test_poll_query_tool.py", line 104, in runTest
> response_data['data']['additional_messages'])
> File "/System/Library/Frameworks/Python.framework/Versions/2.7/
> lib/python2.7/unittest/case.py", line 802, in assertIn
> if member not in container:
> TypeError: argument of type 'NoneType' is not iterable
>
> ----------------------------------------------------------------------
>
> Please provide some more details. Is this failing for particular server
version?
I am not getting any error with this patch and without this patch on PY2
and PY3 with a single/multiple servers.
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
view thread (185+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507
In-Reply-To: <CAFOhELc+=eod5gtxQvRw=G2t=BQWb=2SgHOxbLrA2wxEROutzQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox