public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin4 PATCH: Domain Module
Date: Thu, 17 Mar 2016 23:09:17 +0530
Message-ID: <CAFOhELc0PU6yuMGRX5xDj=njVnqVj7Jj632VY4AS9j0NRn60Bg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyRLYFv_SxNNGdsGN=Up7d3WT_EQz0-h9P+S+0oRtjaYg@mail.gmail.com>
References: <CAFOhELf-n8mM4h8RZuqxUs-Z+f97N6Ux5KT6aoAdWFiHVVURyw@mail.gmail.com>
	<CAFOhELf-QTMAgNkTT8AsRwJ38Jn_1BSFRV_G5ZmcHnrKmPsTog@mail.gmail.com>
	<CACCA4P1caumXOrpEXrrETMuNGj3G3ctY-PN9=V6GUPF=dTBnWg@mail.gmail.com>
	<CAFOhELdgb566u+4XXOOP4pDCF4GGzK8JZzLrrTuPt=OprsqG5Q@mail.gmail.com>
	<CACCA4P06PrJ2-VodT133sheH1i+7zc_M_y_me6KfRHkLqrQ7gg@mail.gmail.com>
	<CAFOhELc1OAz3BDWkKC0e0xA8sPBKiO-4vWJQ7ipMYmKC-C6YzA@mail.gmail.com>
	<CACCA4P1uFijfEV6vvETXX=qjafhGZsOacdi7Og+7edaBb4erxA@mail.gmail.com>
	<CAFOhELePQ_m8zmbORLmO3PUY5yTA5o_9suQKk0Tox8A7Fb8ovw@mail.gmail.com>
	<CAFOhELcq3oiXAC3LVCvxVA5i8qjCh=Sk77MsVUnZB2VhwzmLKw@mail.gmail.com>
	<CA+OCxozpzStRAm=rm3s2ZdtehMt6WfQTVEFT3fssorNc5M2UHQ@mail.gmail.com>
	<CA+OCxoxkows1UUgaddq3+R2VcTW9Vmc3QCKdrtd1sNP+fDsHTg@mail.gmail.com>
	<CAFOhELfzRV1WoA7A87=g5Nb9uvU3rLL2jPUCEid66pqzFdrfRQ@mail.gmail.com>
	<CA+OCxoxWUGqp5P_KSUbKBXH-i2AD4E8STWcfxsy01iVAymU-Og@mail.gmail.com>
	<CAFOhELfA8rTWKJr_P9=Z6--oeE0m7E40nZFr=WFSs2g8=3RmAg@mail.gmail.com>
	<CAFOhELewp6_jT35CkG8u8-+K+H9AhFS_QpiwXfMcCib6vJyJBg@mail.gmail.com>
	<CA+OCxoyRLYFv_SxNNGdsGN=Up7d3WT_EQz0-h9P+S+0oRtjaYg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

I have a query regarding your below feedback :

* - Default values should be auto-quoted when necessary (ie. strings, on a
text-based domain).*

To resolve this, I have checked the typcategory field from pg_type for the
base_type selected for the Domain.
If the typcategory is String type  (i.e. S), then only I have used
qtLiteral function to quote the default value.

Is this right approach or not?

Thanks,
Khushboo


On Wed, Mar 16, 2016 at 9:40 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
> <[email protected]> wrote:
> > Hi,
> >
> > Please find the updated Domain Module Patch.
> >
> > To test this patch, please apply Backgrid Textarea Cell Patch before
> this.
>
> Thanks. I believe with the following fixes, we'll be done :-)
>
> - Default values should be auto-quoted when necessary (ie. strings, on
> a text-based domain).
>
> - "System Domain?" should be in the General section, between owner and
> comment.
>
> - The switches should use the same colouring/styling as other objects, e.g.
>
>           options: {
>             'onText': 'Yes', 'offText': 'No',
>             'onColor': 'success', 'offColor': 'primary',
>             'size': 'small'
>           }
>
> - Please remove the Schema property from the main properties tab (not
> the properties dialogue).
>
> - No icon is show for Checks on the Dependents tab for a domain.
>
> - The add button on the Security Labels tab is spelt "Add". Why is
> that? Other instances of this grid use "ADD" which is the default in
> backform.pgadmin.js.
>
> - Dependencies on domain check constraints are listed as being on a
> "Type" not a "Domain".
>
> - If adding a domain constraint using the grid on the Domain dialogue,
> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
> columns at the end. Unchecking it for an existing constraint should be
> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>
> - If I switch the "Don't Validate" switch on a constraint, there are
> leading blank lines in the generated SQL. The same occurs when adding
> a comment to a constraint.
>
> - I think we need to reverse the meaning of "Don't Validate" and
> rename to match the "Valid?" field that's on the properties list.
> Otherwise it's not clear they're the same thing.
>
> - s/Not Null/Not Null?/
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (29+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgAdmin4 PATCH: Domain Module
  In-Reply-To: <CAFOhELc0PU6yuMGRX5xDj=njVnqVj7Jj632VY4AS9j0NRn60Bg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox