public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin4 PATCH: Domain Module
Date: Wed, 16 Mar 2016 15:02:32 +0530
Message-ID: <CAFOhELfA8rTWKJr_P9=Z6--oeE0m7E40nZFr=WFSs2g8=3RmAg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxWUGqp5P_KSUbKBXH-i2AD4E8STWcfxsy01iVAymU-Og@mail.gmail.com>
References: <CAFOhELf-n8mM4h8RZuqxUs-Z+f97N6Ux5KT6aoAdWFiHVVURyw@mail.gmail.com>
	<CAFOhELf-QTMAgNkTT8AsRwJ38Jn_1BSFRV_G5ZmcHnrKmPsTog@mail.gmail.com>
	<CACCA4P1caumXOrpEXrrETMuNGj3G3ctY-PN9=V6GUPF=dTBnWg@mail.gmail.com>
	<CAFOhELdgb566u+4XXOOP4pDCF4GGzK8JZzLrrTuPt=OprsqG5Q@mail.gmail.com>
	<CACCA4P06PrJ2-VodT133sheH1i+7zc_M_y_me6KfRHkLqrQ7gg@mail.gmail.com>
	<CAFOhELc1OAz3BDWkKC0e0xA8sPBKiO-4vWJQ7ipMYmKC-C6YzA@mail.gmail.com>
	<CACCA4P1uFijfEV6vvETXX=qjafhGZsOacdi7Og+7edaBb4erxA@mail.gmail.com>
	<CAFOhELePQ_m8zmbORLmO3PUY5yTA5o_9suQKk0Tox8A7Fb8ovw@mail.gmail.com>
	<CAFOhELcq3oiXAC3LVCvxVA5i8qjCh=Sk77MsVUnZB2VhwzmLKw@mail.gmail.com>
	<CA+OCxozpzStRAm=rm3s2ZdtehMt6WfQTVEFT3fssorNc5M2UHQ@mail.gmail.com>
	<CA+OCxoxkows1UUgaddq3+R2VcTW9Vmc3QCKdrtd1sNP+fDsHTg@mail.gmail.com>
	<CAFOhELfzRV1WoA7A87=g5Nb9uvU3rLL2jPUCEid66pqzFdrfRQ@mail.gmail.com>
	<CA+OCxoxWUGqp5P_KSUbKBXH-i2AD4E8STWcfxsy01iVAymU-Og@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

On Wed, Mar 16, 2016 at 2:55 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Wed, Mar 16, 2016 at 9:18 AM, Khushboo Vashi
> <[email protected]> wrote:
> >
> >>> - Owner and schema should be allowed to be left blank (and then default
> >>> to the current user/schema)
> >
> > Done
>
> Oh, sorry - that design changed a while back, and I've updated all the
> existing nodes already. I thought I'd mentioned that. All we do now is
> pre-set the default values for those two fields.
>
I have done in this way only. Sorry for the misunderstanding.

> >>> - When adding constraints, I should be able to type directly into the
> >>> grid. Expanding the row should be optional.
> >
> > I have made the grid non-editable explicitly as the Check constraint
> control
> > is multi-line control and right now there is no support in the grid for
> the
> > multi-line control.
>
> Not sure I follow - the mockup design you sent months ago allowed you
> to type into the grid, and expand a row to show all fields if you
> wanted. That is an *absolutely essential* feature enhancement for
> pgAdmin 4 - it's required by the table design (though this will change
> a little in other ways, like positioning of the expand row button),
> and should be used here:
>
> https://www.lucidchart.com/documents/edit/610ce42d-c397-48ff-a5e7-bd92c4995715/0
>
> All other controls other than text-area are supported in back-grid.
I will try to incorporate text-area as well, so we can directly type into
the grid for this control also.


> >>> - The comment column on the constraints grid expands when the text
> >>> reaches ~50% of the width. It should be a fixed size (and use 100% of
> the
> >>> space available, less appropriate margins)
> >
> > I have applied the size for the each header of the grid, but if the given
> > input will be without space in the grid then it will expand. For this, we
> > can make table layout fixed. So, please suggest, should I do that or not?
>
> Yes, I think it should be fixed. If the grid row is expanded,
> presumably it'll show in a multi-line field anyway? Plus the
> properties will use a multi-line field as well.
>
> Okay.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (29+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgAdmin4 PATCH: Domain Module
  In-Reply-To: <CAFOhELfA8rTWKJr_P9=Z6--oeE0m7E40nZFr=WFSs2g8=3RmAg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox