public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Pradip Parkale <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PgAdmin][RM4237]: User can not change value of Datetime picker control using keyboard (Accessibility).
Date: Tue, 10 Mar 2020 14:20:29 +0530
Message-ID: <CAFOhELc8C2cxgYG7XdbGFHKFt-Y5HNv3WrzQmmh6EXQ99M2sLw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDckCrh4650O+y-YcAiB1ja-inx-soout-WMLRQmSCBAAQ@mail.gmail.com>
References: <CAJ9T6SsfnVFvZaY+ysBi+WQ3Ofr=Rw58AApzVXb6T1q1h7c4cA@mail.gmail.com>
	<CANxoLDdPb6WsA2HDBkgv9km+TU1QB6n_kPeynjYUSTK3h1PY1A@mail.gmail.com>
	<CAJ9T6SsEqF7dK5QXCeYE8oyuhxnVYAXRtsKunSS1UndcBXXq9Q@mail.gmail.com>
	<CANxoLDckCrh4650O+y-YcAiB1ja-inx-soout-WMLRQmSCBAAQ@mail.gmail.com>

Hi Pradip,

Looks like you have repeated below code in if and else both the conditions.

let $el = this.$el.find('.datetimepicker-input');
let currdate = $el.data('datetimepicker').date().clone();

We can optimize this code by taking these both lines above if condition.

Thanks,
Khushboo

On Tue, Mar 10, 2020 at 1:24 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, patch applied.
>
> On Tue, Mar 10, 2020 at 1:17 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Akshay,
>> I have already added the code to change the time. To select the time
>> picker, the user needs to press 'Alt+T' (Option+T for mac)  and then
>> Up/Down arrows to change the minutes and Alt + Up/Down to change the hours.
>>
>> On Mon, Mar 9, 2020 at 11:09 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Pradip
>>>
>>> I have tested the patch. I am able to navigate the dates using the
>>> keyboard, but not able to select the year/month and time. Can you please
>>> work on it and send the patch again.
>>>
>>> On Sat, Mar 7, 2020 at 7:00 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is a patch to change the Datetime picker value using a
>>>> keyboard.
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> QMG, EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PgAdmin][RM4237]: User can not change value of Datetime picker control using keyboard (Accessibility).
  In-Reply-To: <CAFOhELc8C2cxgYG7XdbGFHKFt-Y5HNv3WrzQmmh6EXQ99M2sLw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox