public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: Fixed typos in datamodel.js
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: Fixed typos in datamodel.js
@ 2016-04-18 06:25 Khushboo Vashi <[email protected]>
  2016-04-18 06:40 ` Re: [pgAdmin4][Patch]: Fixed typos in datamodel.js Ashesh Vashi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2016-04-18 06:25 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Due to some typos in datamodel.js, the application does not load properly
in Google Chrome (ver: 39).

Fixed typos in datamodel.js

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_datamodel_js.patch (888B, 3-pgAdmin4_datamodel_js.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/datamodel.js b/web/pgadmin/browser/static/js/datamodel.js
index 71bd959..fa60f7c 100644
--- a/web/pgadmin/browser/static/js/datamodel.js
+++ b/web/pgadmin/browser/static/js/datamodel.js
@@ -221,12 +221,13 @@ function(_, pgAdmin, $, Backbone) {
               delete obj;
             } else if (obj instanceof Backbone.Collection) {
               obj.each(function(m) {
-                if (m instanceof Bakbone.DataModel) {
+                if (m instanceof Backbone.DataModel) {
                   obj.reset();
                   obj.clear(opts);
                 }
               });
-              Backbone.Collection.prototype.reset.apply(obj, {opts});
+              if (!(opts instanceof Array)){ opts = [opts] }
+              Backbone.Collection.prototype.reset.apply(obj, opts);
               delete obj;
             }
           }


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: Fixed typos in datamodel.js
  2016-04-18 06:25 [pgAdmin4][Patch]: Fixed typos in datamodel.js Khushboo Vashi <[email protected]>
@ 2016-04-18 06:40 ` Ashesh Vashi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Ashesh Vashi @ 2016-04-18 06:40 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Mon, Apr 18, 2016 at 11:55 AM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Due to some typos in datamodel.js, the application does not load properly
> in Google Chrome (ver: 39).
>
> Fixed typos in datamodel.js
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-04-18 06:40 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-18 06:25 [pgAdmin4][Patch]: Fixed typos in datamodel.js Khushboo Vashi <[email protected]>
2016-04-18 06:40 ` Ashesh Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox