public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: SQL Help Fix
Date: Fri, 15 Apr 2016 18:40:13 +0530
Message-ID: <CAFOhELcj305yVQG9gn7p7ZcnfwnL2kxcVtyFTJQmoYCbFiW63A@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

The SQL Help Tab does not load the Help page on the Google Chrome (version:
39.0) browser.

Please find the attached patch for the same.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_sql_help.patch (671B, 3-pgAdmin4_sql_help.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 331d818..d38eee7 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -731,7 +731,7 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
           minor = Math.floor(server.version / 100) - (major * 100)
 
           url = url.replace('$VERSION$', major + '.' + minor)
-          if (!url.endsWith('/')) {
+          if (!S(url).endsWith('/')) {
             url = url + '/'
           }
           if (that.sqlCreateHelp == '' && that.sqlAlterHelp != '') {

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: SQL Help Fix
  In-Reply-To: <CAFOhELcj305yVQG9gn7p7ZcnfwnL2kxcVtyFTJQmoYCbFiW63A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox