public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: SQL Help Fix
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: SQL Help Fix
@ 2016-04-15 13:10  Khushboo Vashi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2016-04-15 13:10 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

The SQL Help Tab does not load the Help page on the Google Chrome (version:
39.0) browser.

Please find the attached patch for the same.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_sql_help.patch (671B, 3-pgAdmin4_sql_help.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 331d818..d38eee7 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -731,7 +731,7 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
           minor = Math.floor(server.version / 100) - (major * 100)
 
           url = url.replace('$VERSION$', major + '.' + minor)
-          if (!url.endsWith('/')) {
+          if (!S(url).endsWith('/')) {
             url = url + '/'
           }
           if (that.sqlCreateHelp == '' && that.sqlAlterHelp != '') {


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: SQL Help Fix
@ 2016-04-15 13:27  Dave Page <[email protected]>
  parent: Khushboo Vashi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-04-15 13:27 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks, committed.

On Fri, Apr 15, 2016 at 2:10 PM, Khushboo Vashi
<[email protected]> wrote:
> Hi,
>
> The SQL Help Tab does not load the Help page on the Google Chrome (version:
> 39.0) browser.
>
> Please find the attached patch for the same.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-04-15 13:27 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-15 13:10 [pgAdmin4][Patch]: SQL Help Fix Khushboo Vashi <[email protected]>
2016-04-15 13:27 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox