public inbox for [email protected]  
help / color / mirror / Atom feed
From: Khushboo Vashi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
To: Chethana Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
Date: Wed, 30 Jan 2019 16:39:45 +0530
Message-ID: <CAFOhELcqqKvPGYk=NSV0hpN+iBut_g1B_Azk2c_Hoe-fRerLtg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQ_05r3Az6pJYjs60PC+ARswhHz=sEZPnUfST7gfDaqtA@mail.gmail.com>
References: <CAKKotZQ_05r3Az6pJYjs60PC+ARswhHz=sEZPnUfST7gfDaqtA@mail.gmail.com>

Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and
Proposed_design). With this patch the *Note* section design has been
changed.
We need your suggestion on this to improve it as I feel it needs
improvement.

Thanks,
Khushboo


On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA minor patch to fix the style, changed the background colour and text
> colour so that it can be readable.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


Attachments:

  [image/png] Existing_design.png (630.2K, 3-Existing_design.png)
  download | view image

  [image/png] Proposed_design.png (633.1K, 4-Proposed_design.png)
  download | view image

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
  In-Reply-To: <CAFOhELcqqKvPGYk=NSV0hpN+iBut_g1B_Azk2c_Hoe-fRerLtg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox