public inbox for [email protected]  

help / color / mirror / Atom feed
From: Khushboo Vashi <[email protected]>
To: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS
Date: Wed, 7 Mar 2018 10:00:36 +0530
Message-ID: <CAFOhELdAKvvd-g6OjyFEYaOzGmj9WMvzFW3dGgfVN3PqPEuBJQ@mail.gmail.com> (raw)
In-Reply-To: <CAE+jjamqaZT31xVa5o+eQtxMh5t3affFuNgKFhbfJZyGaaf7SQ@mail.gmail.com>
References: <CAFOhELexqR-ogQyyR-Ymgok=y2vZBj4o2V0Bo_O_5NAkwBoQQQ@mail.gmail.com>
	<CAE+jjanPh-eUmjY=AiUKif3VWPwq3NAM7CXan5Xxa3+kZMxKGw@mail.gmail.com>
	<CAFOhELfeb=nH7dDHmEpd7L+FsiqyOJB921PuHMrmJ-uQJy_7kA@mail.gmail.com>
	<CAE+jjamqaZT31xVa5o+eQtxMh5t3affFuNgKFhbfJZyGaaf7SQ@mail.gmail.com>

On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira <
[email protected]> wrote:

> Hello Khushboo,
>
> All tests pass on CI, and the code looks good. The only issue that I found
> was the line:
>  os.path.dirname(os.path.realpath(__file__)) + "/../templates"
>
> that will not work on windows.
> So I updated your patch with the change and it should be ready to merge.
>
> Thanks Joao.

Thanks
> Joao
>
> On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Joao,
>>
>> Thanks for reviewing.
>>
>> On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira <
>> [email protected]> wrote:
>>
>>> Hello Kushboo,
>>>
>>> Can we add some Unit test to ensure this does not happen again?
>>>
>>> Please find the attached patch with the unit tests.
>>
>>> Thanks
>>> Joao
>>>
>>> Thanks,
>> Khushboo
>>
>>> On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix RM # 3135 - [Web based] Syntax
>>>> error displayed when user try to insert data on table where primray key is
>>>> in captial letters and table contains OIDS
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>


view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS
  In-Reply-To: <CAFOhELdAKvvd-g6OjyFEYaOzGmj9WMvzFW3dGgfVN3PqPEuBJQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox