public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Shaheed Haque <[email protected]>
Subject: Re: Making Kerberos optional in the Python wheel
Date: Mon, 8 Mar 2021 16:50:49 +0530
Message-ID: <CAFOhELdD6R4-iAux02qjwAK3Ox4ovGbkPy-kVeoj71F3bN47Rw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoysyZKdEiP9QsAQY+n1s20D2FhYuECRFhoW5eypdYOLwA@mail.gmail.com>
References: <CA+OCxowzCN8wznYjG_631tB2XYgqv5LCXkD49jkXAUtD7d9t3g@mail.gmail.com>
	<CA+OCxoysyZKdEiP9QsAQY+n1s20D2FhYuECRFhoW5eypdYOLwA@mail.gmail.com>

Hi Dave,

The patch looks good to me.

Thanks,
Khushboo

On Mon, Mar 8, 2021 at 4:42 PM Dave Page <[email protected]> wrote:

> Has anyone been able to review this?
>
> On Thu, Mar 4, 2021 at 10:02 AM Dave Page <[email protected]> wrote:
>
>> There have been a couple of complaints that the latest Python wheel
>> distribution doesn't install cleanly. This happens when there is no
>> pre-built gssapi wheel on PyPi that matches the users combination of Python
>> version and platform, *and* the MIT Kerberos development headers etc. are
>> not present on the system, so the source wheel cannot be compiled.
>>
>> This seems like it's a bit onerous on users, especially if they're on
>> Windows where they'll also need a suitable compiler to be installed. The
>> attached patch aims to address that by making the Kerberos support optional
>> (thankfully, Khushboo made the code handle lack of gssapi libraries).
>>
>> To install without gssapi, users would simply do:
>>
>> pip install pgadmin4
>>
>> or
>>
>> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl
>>
>> To install with gssapi:
>>
>> pip install pgadmin4['kerberos']
>>
>> or
>>
>> pip install pip install /path/to/pgadmin4-5.0-py3-none-any.whl['kerberos']
>>
>> The patch also cleans up some old cruft that was required for now
>> unsupported Python versions.
>>
>> Thoughts?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Making Kerberos optional in the Python wheel
  In-Reply-To: <CAFOhELdD6R4-iAux02qjwAK3Ox4ovGbkPy-kVeoj71F3bN47Rw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox