public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#5261] Support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers
Date: Thu, 19 Mar 2020 13:25:40 +0530
Message-ID: <CAFOhELdLxRaQ4gULv8KHen3CP9c2M1PPyPXX-S8Eba4b0UBK=Q@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcosUhAeRAY1MUOP4+LHUVjA6k9kZZOAp8KO4bjBEkThw@mail.gmail.com>
References: <CANxoLDcosUhAeRAY1MUOP4+LHUVjA6k9kZZOAp8KO4bjBEkThw@mail.gmail.com>

Hi Akshay,

The patch looks good to me.

Apart from this patch, I encountered below error.

"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/schema_diff_utils.py",
line 271, in get_sql_from_submodule_diff
   parent_target_data=target
 File
"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py",
line 790, in ddl_compare
   target_data=parent_target_data)
 File
"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py",
line 142, in wrap
   return f(*args, **kwargs)
 File
"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/partitions/__init__.py",
line 508, in get_sql_from_diff
   schema_diff=True)
 File
"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py",
line 1369, in get_partitions_sql
   part_data['partition_scheme'] = self.get_partition_scheme(row)
 File
"/Users/khushboovashi/Projects/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/utils.py",
line 695, in get_partition_scheme
   for row in data[part_keys]:
KeyError: 'partition_keys'


Thanks,
Khushboo

On Wed, Mar 18, 2020 at 4:28 PM Akshay Joshi <[email protected]>
wrote:

> Hi Hackers,
>
> Attached is the patch to add support for Collation, FTS Templates, FTS
> Dictionaries, FTS Configurations and FTS Parsers in Schema Diff Tool.
>
> The patch contains some minor fix where parameters are added in the
> difference list even though it's size is zero. I have also added the test
> cases.
>
> Please review it.
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#5261] Support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers
  In-Reply-To: <CAFOhELdLxRaQ4gULv8KHen3CP9c2M1PPyPXX-S8Eba4b0UBK=Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox