public inbox for [email protected]
help / color / mirror / Atom feedFrom: Khushboo Vashi <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: [email protected]
Cc: Aditya Toshniwal <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Thu, 27 Jul 2023 16:26:46 +0530
Message-ID: <CAFOhELdT30L7OYj3MbQtkaHLHaRuMP3inV4t_wHkiJBOiJ=8TA@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdpnz1o-CYCmH=3x2u6XMWDXd6gbiWejL3dMq+LSu8QDQ@mail.gmail.com>
References: <CAKi=nneJvdbFyeDKnuQTVEnhNK0Zjdx5TWSwGUUSZO9YTC5E7Q@mail.gmail.com>
<CANxoLDfO4BE0xvGLA3EBYyAzt3hCmuRcMY_pR3Zci9nPbL7P1Q@mail.gmail.com>
<CAKi=nndnvAwgXVC=i=x3sSxNS9UCfks+EQWEjx8n5=u9CCP8og@mail.gmail.com>
<CANxoLDeNzZkxYEnLdkFMkugvk7_k+BDSt6AoH83aaMkP+VZirQ@mail.gmail.com>
<CAM9w-_mC2JKvxKKRwF7xCzoggoo0_XqBgUyqWDxXqSRQs_a0eg@mail.gmail.com>
<CAKi=nncQ+OqkJ2PfvNNs40h5PfkO57YKTMEXdYeOpxUXhTzj5A@mail.gmail.com>
<CA+OCxowriuEED8BC7DRZKwCM3dOfNaDWhf+vhJsH2PWq88yc7w@mail.gmail.com>
<CAKi=nncY7wdMyqT2tKRAVWDaFSsgUS_qnOz0aifd-BorScUNSw@mail.gmail.com>
<CA+OCxoyog3cqhZcEQ1xenmHUFMLM+VS8j91GM_RnU3VK8bGjaQ@mail.gmail.com>
<CAKi=nncGiLTK36jQWnGL-0DToo4qTqojf+iLbDvRTfk2z_48Uw@mail.gmail.com>
<CA+OCxowEmnWJHRa=QnuZpn42Cn594XZVduMPJuOg5MbdeQx0aw@mail.gmail.com>
<CAKi=nnfMHZSGP3G+gS9JSLNp2C=BHF2ztsz6W0mpBREc4y=hiQ@mail.gmail.com>
<CA+OCxowt2XSCEOxZ+Mz1CzMGQv5MCNV+GZO2b3E5PtZj1YgYOA@mail.gmail.com>
<CAKi=nndoS4g8MmOBD6wZKCtGotpmxDa17rq8-obv3B9MaSbYjg@mail.gmail.com>
<CA+OCxozjkCkVOFabHbMP+1sZ+hKftXA6Z8q00c+A2=mYHKbcuQ@mail.gmail.com>
<CAKi=nncko8TQVyGtEn_89DtZoztdhOA_e2-wSe8wROjZADgbXg@mail.gmail.com>
<CAKi=nnfj2OcTBkUoWwMZ5YifExgrxs9Pbt42-2W1+n32LEmgvQ@mail.gmail.com>
<CAG7mmow-bPFycSZeY_-=JbhmdH7qHud2GHiiZTfcNPhnsruQaA@mail.gmail.com>
<CAKi=nnfeEf6dQYcDyUExJK+1Xo5NgCHrpgfZPjS56B2rrUmd=w@mail.gmail.com>
<CAM9w-_=-jmhjh9Mp98pvwBxp_DDoeMexnR2Y23+=-wR+tsDOiQ@mail.gmail.com>
<CAKi=nneNLFiOUPQ16ZzO1RM8K8V=qoqa=AtmewkRzLjnjJhyUA@mail.gmail.com>
<CAFOhELe-EAiVN6YjmAo1VjW-b+Bw3yPC6Ghxy=X6P-y4EF_EgA@mail.gmail.com>
<CAKi=nndAi2iBN1P5y+XWdTa9EnL5b_FzhK4AG_9duUKxZE5=fw@mail.gmail.com>
<CAKi=nndU8oESoER=MF7yaaUKiNd1fV7GDECGgLv_jumxs8EmTQ@mail.gmail.com>
<CAFOhELdpnz1o-CYCmH=3x2u6XMWDXd6gbiWejL3dMq+LSu8QDQ@mail.gmail.com>
On Thu, Jul 27, 2023 at 1:59 PM Khushboo Vashi <
[email protected]> wrote:
> Hi Sahil,
>
> On Thu, Jul 27, 2023 at 1:09 PM Sahil Harpal <[email protected]>
> wrote:
>
>> On Wed, 12 Jul 2023 at 15:58, Sahil Harpal <[email protected]>
>> wrote:
>>
>>> On Wed, 12 Jul 2023 at 10:47, Khushboo Vashi <
>>> [email protected]> wrote:
>>> [image: image.gif]
>>>
>>>> It fails while applying. Can you please rebase your patch and send it?
>>>>
>>>
>>> Could you please try the attached patch.
>>>
>> Just a follow-up email to check if I can proceed with a similar structure
>> and logic for the remaining disk tab.
>>
> You have made different files tab-wise; it would be more manageable if you
could put them under a subfolder OR start a name with system_state or
something like that.
> If anyone has faced any issues while using it or has any suggestions for
>> improvement, please let me know, and I will make the necessary changes and
>> follow the same approach for the disk tab. Although there is an issue with
>> drive's letters, the I/O analysis of block devices is working just fine on
>> my system, so I can probably start working on it parallelly.
>>
>> Some initial review comments.
>
> - While applying the patch, I got warnings; please fix those.
> - Fix PEP-8 errors (yarn run pep8)
> - Fix the linter errors. Run *yarn run bundle:dev* instead of *yarn run
> webpacker so* you will get the linter errors on every run.
> - If the System Stat extension does not exist, display the appropriate
> message instead of blank graphs.
> - For the first time, graphs start from the opposite side, and after the
> following API call, those get adjusted; please fix that.
> - Please consider the refresh rate for the API calls (preferences settings
> > Dashboards > Refresh rates)
>
> The code review is in progress; I will send my review comments once
> completed.
>
> Thanks,
> Khushboo
>
>
>> Thanks,
>> Sahil
>>
>>
Attachments:
[image/gif] image.gif (42B, 3-image.gif)
download | view image
view thread (106+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
In-Reply-To: <CAFOhELdT30L7OYj3MbQtkaHLHaRuMP3inV4t_wHkiJBOiJ=8TA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox