public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node
Date: Fri, 6 May 2016 15:11:03 +0530
Message-ID: <CAFOhELdWfwBuxUwhjAAB4=vCYFfgLcsMUCS3x5+xw1iKboR5TQ@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

When we try to drop any node and the visibility of the Delete/Drop context
Menu of that node is having dependency on some function then, after
deleting that node object, it gives a JS error.

Please find the attached patch to fix this issue.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_canDrop_fix.patch (1.4K, 3-pgAdmin4_canDrop_fix.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/node.js b/web/pgadmin/browser/templates/browser/js/node.js
index 5810e74..7814934 100644
--- a/web/pgadmin/browser/templates/browser/js/node.js
+++ b/web/pgadmin/browser/templates/browser/js/node.js
@@ -89,7 +89,7 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
           applies: ['object', 'context'], callback: 'delete_obj',
           priority: 3, label: '{{ _("Delete/Drop") }}',
           data: {'url': 'drop'}, icon: 'fa fa-trash',
-          enable: _.isFunction(self.canDrop) ? function() { return self.canDrop.apply(self, arguments); } : false
+          enable: _.isFunction(self.canDrop) ? !!self.canDrop.apply(self, arguments) : (!!self.canDrop)
         }]);
         if (self.canDropCascade) {
           pgAdmin.Browser.add_menus([{
@@ -97,8 +97,8 @@ function($, _, S, pgAdmin, Menu, Backbone, Alertify, pgBrowser, Backform) {
             applies: ['object', 'context'], callback: 'delete_obj',
             priority: 3, label: '{{ _("Drop Cascade") }}',
             data: {'url': 'delete'}, icon: 'fa fa-trash',
-            enable: (_.isFunction(self.canDropCascade) ?
-              function() { return self.canDropCascade.apply(self, arguments); } : true)
+            enable: _.isFunction(self.canDropCascade) ?
+              function() { return self.canDropCascade.apply(self, arguments); } : (!!self.canDropCascade)
           }]);
         }
       }

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][Patch]: Fixed an issue related to the Delete/Drop context Menu of the node
  In-Reply-To: <CAFOhELdWfwBuxUwhjAAB4=vCYFfgLcsMUCS3x5+xw1iKboR5TQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox