Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject:  Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.
Date: Thu, 15 Mar 2018 17:40:25 +0530
Message-ID: <CAFOhELeeaO=9U_RW13ysQKwmfNbJMWx8kR1+o42fqk0M07DZqQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxox2tuMGwKab6VDML4OcPxNZX5=iJso8g2T-FK8XRpGJLA@mail.gmail.com>
References: <CAFOhELf74n8cKE9y_4ppNs31Qi87WDLry+TV7K_bpAmdczM2bg@mail.gmail.com>
	<CA+OCxozdsAg3-jv4yhv9G9Kre4KmO+zWYfkzmVTGrfjX=OkvWA@mail.gmail.com>
	<CAFOhELfcJSs+nE3Z5bgFfNkVVmuavi8GvQ-uwrKPO7Y+hVf79w@mail.gmail.com>
	<CA+OCxowgspEsUwg8cGcyZH=whCS8n26NePw0cPycSJ=H+PZT8Q@mail.gmail.com>
	<CAFOhELdv_EFFctXmLNVTeH4dj7EdQ_oabAUxeC+oho+S4Q-Jww@mail.gmail.com>
	<CA+OCxoxKoZ7Mijapqb=oFh34jFNrs5xeuRWNH+gZhMtxkGFu3w@mail.gmail.com>
	<CA+OCxoz-N=7QMVh05R6dpQxugyx-z=+4TPOYB6z4vhZA_Ks3tA@mail.gmail.com>
	<CAFOhELftpncVyoK=H4L-yZco_XWbk+x0XwRx1A5QgLkgXpu2MQ@mail.gmail.com>
	<CA+OCxoxajGF0w68UESWB0c_4e=MtoQDsco8DFGtMgpGviiykjA@mail.gmail.com>
	<CAFOhELfMzT6uzhR4d_MAA0Rr-0h1Wk1ypj1c3S0gBojoE0NC-Q@mail.gmail.com>
	<[email protected]>
	<CAFOhELdZ0uQ_h3t7K=vQTnebd0-1fUq110rKEg_Lj+eFti4LtQ@mail.gmail.com>
	<CA+OCxoy+7g7c4siJEZ6QpQYddptnZMREzAqcD_R=mKSWNR3wtw@mail.gmail.com>
	<CAFOhELeRZwzbUN10cA92srpAH9PxRzqqVnF7dfMhohF8p9c6Ag@mail.gmail.com>
	<CA+OCxox2tuMGwKab6VDML4OcPxNZX5=iJso8g2T-FK8XRpGJLA@mail.gmail.com>

On Thu, Mar 15, 2018 at 3:13 AM, Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, Mar 13, 2018 at 11:18 PM, Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Wed, Mar 14, 2018 at 2:18 AM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Tue, Mar 13, 2018 at 12:46 AM, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Tue, Mar 13, 2018 at 9:39 AM, Dave Page <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On 12 Mar 2018, at 23:12, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Mar 13, 2018 at 2:29 AM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> So I was trying to test this, and every time I try to run a backup,
>>>>>> I'm getting the following, with or without your patch:
>>>>>>
>>>>>> (sqlite3.ProgrammingError) You must not use 8-bit bytestrings unless
>>>>>> you use a text_factory that can interpret 8-bit bytestrings (like
>>>>>> text_factory = str). It is highly recommended that you instead just switch
>>>>>> your application to Unicode strings. [SQL: u'INSERT INTO process (pid,
>>>>>> user_id, command, "desc", arguments, logdir, start_time, end_time,
>>>>>> exit_code, acknowledge) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)']
>>>>>> [parameters: (180312205250107339, 1, u'/Library/PostgreSQL/9.4/bin/pg_dump',
>>>>>> 'ccopy_reg\n_reconstructor\np0\n(cpgadmin.tools.backup\nBack
>>>>>> upMessage\np1\nc__builtin__\nobject\np2\nNtp3\nRp4\n(dp5\nS\'cmd\'\np6\nV
>>>>>> --file "/Users/dpage/foo.dmp" --host "127.0.0.1" --port "5432" --username
>>>>>> "postgres" --no-password --verbose --format=c --blobs
>>>>>> "\xe9"\np7\nsS\'backup_type\'\np8\nI3\nsS\'database\'\np9\nV
>>>>>> \xe9\np10\nsS\'bfile\'\np11\nS\'foo.dmp\'\np12\nsS\'sid\'\np13\nI1\nsb.',
>>>>>> u'--file,/Users/dpage/foo.dmp,--host,127.0.0.1,--port,5432,-
>>>>>> -username,postgres,--no-password,--verbose,--format=c,--blobs,\xe9',
>>>>>> '/var/lib/pgadmin/sessions/process_logs/180312205250107339', None,
>>>>>> None, None, None)]
>>>>>>
>>>>>> Any thoughts as to what's going on? I wasn't getting this on my other
>>>>>> laptop, and I can't think what else we would have changed to cause this.
>>>>>>
>>>>>> Deleting all the records from the process table from SQLITE will
>>>>> solve this problem.
>>>>> There were few issues related to encoding-decoding in my old patches,
>>>>> you may have applied those.
>>>>>
>>>>>
>>>>> I deleted the database entirely, and still saw the problem.
>>>>>
>>>>> I have tried many things to reproduce this but couldn't.  I faced this
>>>> issue when I was fixing the issue but not now.
>>>> Please make sure to delete the old session and a process table (or
>>>> database) and apply my latest patch. (of course you do this :) )
>>>> I have PY - 2.7.12, psycopg2 - 2.7.4 and SQLAlhemy -1.0.14 to be more
>>>> specific.
>>>>
>>>>>
>>> Well I eventually got this to work (basically recreated most of my dev
>>> environment), so I committed the patch as it's clearly an improvement.
>>>
>>> Thanks.
>>
>>> I can still reproduce the display issue I mentioned though - see the
>>> attached screenshot which shows &#233; in a couple of places. I wonder if
>>> it's because the database name is just a single character in my tests,
>>> whilst you had some other unicode characters in the string?
>>>
>>> I have tested it with a single character also but couldn't reproduce
>> this. Please find the attached screen-shot for the same.
>> Can you please take a complete screen shot of the screen (with left side
>> tree and properties panel of the database) and send it?
>>
>
> Sure - attached.
>
>
I didn't find any root cause as the below line responsible for un-escaping
the html and it is clearly shown that it is not happening in your case.
$header.find('.bg-detailed-desc').html(_.unescape(self.detailed_desc));


> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re:  Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.
  In-Reply-To: <CAFOhELeeaO=9U_RW13ysQKwmfNbJMWx8kR1+o42fqk0M07DZqQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox