public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4633] Bad view in partitioned tables
Date: Mon, 6 Jan 2020 12:01:24 +0530
Message-ID: <CAFOhELfN6FvKObhO_Qe8OdkjgbjHzz3R03Jf5Rv-LBghPfq0QQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcU_NqABtQA2H5zsFjK6Pb8evdGOBoNGxekvx9KroRmow@mail.gmail.com>
References: <CANxoLDcU_NqABtQA2H5zsFjK6Pb8evdGOBoNGxekvx9KroRmow@mail.gmail.com>

Hi Akshay,

On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi <[email protected]>
wrote:

> Hi Hackers
>
> Attached is the patch to support the view part of the multilevel
> partitions. Users can perform all the operations except creating the
> partitions as a partitioned table. Users can create a partition table
> separately and attach it as a partition of another partition table.
>
Multilevel partitions are now manageable through the tree view except
creating a partition table of existing partition (which you already
mentioned).
One more problem that we already discussed that automatic tree refresh of
the multilevel partitions is not working due to our structure which is
going to be handled by the new RM.

Some of the minor review comments.
- _get_children_nodes name can be changed as it more like private method
but we are using it outside of the class itself.
- Stats of partition table is not displayed, but I think that is not
related to this patch, so can be fixed later.

Thanks,
Khushboo

>
> There are two problems mentioned in the RM. I have fixed the first one and
> we won't fix the second problem as by design we decided to show Partitions
> like Schema->Table->Partitions
>
> Please review it.
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM4633] Bad view in partitioned tables
  In-Reply-To: <CAFOhELfN6FvKObhO_Qe8OdkjgbjHzz3R03Jf5Rv-LBghPfq0QQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox