public inbox for [email protected]  

help / color / mirror / Atom feed

From: Khushboo Vashi <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package
Date: Wed, 30 Jan 2019 10:17:38 +0530
Message-ID: <CAFOhELfkaH0Edrv7VNmQXNjypo3pyL7NtyV9e-64Q8oGoif5Bg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyxdYFWdCPcwqmeVAjhB=NdRF7aOAb0HptPRDv0FY7meA@mail.gmail.com>
References: <CANxoLDe5=7hu-K66nXcRHB2sQ84CjEGkBC8Fg=5FFepbh7vbbA@mail.gmail.com>
	<CA+OCxoyxdYFWdCPcwqmeVAjhB=NdRF7aOAb0HptPRDv0FY7meA@mail.gmail.com>

Hi Akshay,

The issue has been fixed with this patch but I feel we need code
refactoring of the existing code especially the loop in which we find the
required string.
What's your thought?

Also, please remove the datagrid/__init__.py file from the patch which I
assume you have sent by mistake.

Thanks,
Khushboo


On Tue, Jan 29, 2019 at 4:49 PM Dave Page <[email protected]> wrote:

> Khushboo, can you review this please? If you're happy with it, Akshay
> can commit.
>
> Thanks.
>
> On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi
> <[email protected]> wrote:
> >
> > Hi Hackers,
> >
> > Attached is the patch to fix RM 3927 "Unable to debug the procedure
> inside package". Problem with the existing code is we assume that
> "PLDBGBREAK" will be always found in the first element of the notification
> list.
> >
> > In this patch we loop through the list and found the string. Apart from
> that patch contains small fix to cancel the transaction of Query Tool when
> panel is closed.
> >
> > Please review it.
> >
> > --
> > Akshay Joshi
> > Sr. Software Architect
> >
> >
> > Phone: +91 20-3058-9517
> > Mobile: +91 976-788-8246
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch]: RM 3927 Unable to debug the procedure inside package
  In-Reply-To: <CAFOhELfkaH0Edrv7VNmQXNjypo3pyL7NtyV9e-64Q8oGoif5Bg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox