public inbox for [email protected]  

help / color / mirror / Atom feed

From: Matthew Kleiman <[email protected]>
To: Surinder Kumar <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: George Gelashvili <[email protected]>
Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values
Date: Tue, 4 Apr 2017 12:37:34 -0400
Message-ID: <CAFS4TJbr9cCQUgOVXHuLBFtsxqo7ka3-0DpyAZ6DKPOTm2ysgg@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D_SSL81uT4AqsRr8WPABWA6S-iE34OxLb8YqfVN3myeJg@mail.gmail.com>
References: <CAM5-9D_SSL81uT4AqsRr8WPABWA6S-iE34OxLb8YqfVN3myeJg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Surinder,

We looked at your fix for default values in the query tool editor.

We think the user experience could be further improved by seeing the actual
default value instead of the empty cell.

As an intermediate step, there would be user value in seeing "[default]"
instead of the blank cell (or what used to be "[null]").

Thanks,
George and Matt



On Sat, Apr 1, 2017 at 7:45 AM, Surinder Kumar <
[email protected]> wrote:

> Hi
>
> Issues fixed:
>
> 1. If a column is defined with a default modifier, there is now way to
> insert the row with those defaults.
> The column will be left blank and it will take default value automatically.
>
> 2. If a column has a not-null constraint then an error is returned and
> the row is not inserted.
> The column will be left blank
> ​ ​
>
> ​The default values for new added rows will be displayed on
> refresh/execute.
>
> Please find attached patch and review.
>
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

view thread (25+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values
  In-Reply-To: <CAFS4TJbr9cCQUgOVXHuLBFtsxqo7ka3-0DpyAZ6DKPOTm2ysgg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox