public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yosry Muhammad <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: [GSoC] Finalized First Patch
Date: Thu, 11 Jul 2019 15:20:17 +0200
Message-ID: <CAFSMqn_HLvsNAN4nQKX4qrea5vA8U0J87jGncyZ68hyQ24-3Jw@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdt8-dVFk-Jb9TFLahLYu5t-Lf6oNrK6u5HifLvgKGXNA@mail.gmail.com>
References: <CAFSMqn8yLA329GFHSm0Bn4cEqvd+kVoYpCAB5mRDbVF6NNaxxA@mail.gmail.com>
<CAFSMqn8fjFT8CbhB5FAtkN8cd7QH0+XYtSUZmD5J1F38n1189g@mail.gmail.com>
<CA+OCxoz=50F2N6+7dGrarieXNaXiiJw-deSAXd6fSH7SvEaQXw@mail.gmail.com>
<CAFSMqn9HaapnutknGQdG2h0-xyk9qCcGB_wxkPM5iwiHp=fPpg@mail.gmail.com>
<CA+OCxox43r3qH9YNt_gT7TT3s+DkROvf1pvvAKzg663xHzT5VQ@mail.gmail.com>
<CAFOhELeFLVLS_RDTJPH0cLDRP8PUxFfxL05YXcL0+r1addP8dg@mail.gmail.com>
<CAFOhELerRJ3WLau4rXVHvCC=YO9nEpp8qtX+f0tbq0rTqLO5uw@mail.gmail.com>
<CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com>
<CAFOhELdt8-dVFk-Jb9TFLahLYu5t-Lf6oNrK6u5HifLvgKGXNA@mail.gmail.com>
Hi Khushboo,
Please find an updated patch attached with the mentioned import line
removed.
On Thu, Jul 11, 2019 at 6:45 AM Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> On Wed, Jul 10, 2019 at 3:11 PM Yosry Muhammad <[email protected]> wrote:
>
>> Hi,
>>
>> On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Some points I missed:
>>> 1. I assumed that in this patch modification in case of OIDs= True
>>> (without primary key) has not considered as that is not working.
>>>
>>
>> This is not implemented yet. I will work on that in a following patch
>> soon enough.
>>
>> Okay.
>
>> 2. As we are already showing the changed Data prompt on closing the Query
>>> Tool, do we really need the Uncommitted Transaction prompt?
>>>
>>
>> This is needed when auto-commit is off. Saving changes in the data grid
>> is performed as part of the ongoing transaction (or a new one if none is
>> ongoing). After saving the data changes the user should still commit the
>> current transaction for the changes to be commited to the database. This
>> feature is also useful in general when auto-commit is off as users may
>> forget to commit ongoing transactions.
>>
>> One thing I have noticed, when I add a new row and delete it immediately
> without saving it and try to close the query tool, the uncommitted prompt
> is coming.
> In my opinion, it should not come, what do you think?
>
> We should disable the prompt if auto-commit and auto-rollback both are
> enabled.
>
The uncommited prompt does not keep track of what the user has done so far,
it only checks for the current transaction status. If a current transaction
is ongoing, the prompt comes up. If you added a new row then deleted it
without saving, the transaction status is not affected, you must have done
a previous operation and had auto-commit turned off (probably the select
statement).
if auto-commit & auto-rollback are both enabled then there won't be any
ongoing transaction at any point, thus, the prompt will never come up.
Looking forward for any feedback !
Thanks !
--
*Yosry Muhammad Yosry*
Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [GSoC] Finalized First Patch
In-Reply-To: <CAFSMqn_HLvsNAN4nQKX4qrea5vA8U0J87jGncyZ68hyQ24-3Jw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox