public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yosry Muhammad <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: [email protected]
Cc: Akshay Joshi <[email protected]>
Subject: Re: [GSoC] Finalized First Patch
Date: Wed, 10 Jul 2019 11:41:13 +0200
Message-ID: <CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELerRJ3WLau4rXVHvCC=YO9nEpp8qtX+f0tbq0rTqLO5uw@mail.gmail.com>
References: <CAFSMqn8yLA329GFHSm0Bn4cEqvd+kVoYpCAB5mRDbVF6NNaxxA@mail.gmail.com>
<CAFSMqn8fjFT8CbhB5FAtkN8cd7QH0+XYtSUZmD5J1F38n1189g@mail.gmail.com>
<CA+OCxoz=50F2N6+7dGrarieXNaXiiJw-deSAXd6fSH7SvEaQXw@mail.gmail.com>
<CAFSMqn9HaapnutknGQdG2h0-xyk9qCcGB_wxkPM5iwiHp=fPpg@mail.gmail.com>
<CA+OCxox43r3qH9YNt_gT7TT3s+DkROvf1pvvAKzg663xHzT5VQ@mail.gmail.com>
<CAFOhELeFLVLS_RDTJPH0cLDRP8PUxFfxL05YXcL0+r1addP8dg@mail.gmail.com>
<CAFOhELerRJ3WLau4rXVHvCC=YO9nEpp8qtX+f0tbq0rTqLO5uw@mail.gmail.com>
Hi,
On Wed, Jul 10, 2019, 9:14 AM Khushboo Vashi <
[email protected]> wrote:
> Some points I missed:
> 1. I assumed that in this patch modification in case of OIDs= True
> (without primary key) has not considered as that is not working.
>
This is not implemented yet. I will work on that in a following patch soon
enough.
2. As we are already showing the changed Data prompt on closing the Query
> Tool, do we really need the Uncommitted Transaction prompt?
>
This is needed when auto-commit is off. Saving changes in the data grid is
performed as part of the ongoing transaction (or a new one if none is
ongoing). After saving the data changes the user should still commit the
current transaction for the changes to be commited to the database. This
feature is also useful in general when auto-commit is off as users may
forget to commit ongoing transactions.
Thanks and Regards :D
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [GSoC] Finalized First Patch
In-Reply-To: <CAFSMqn_gEi1JyeHdeFqWKtjg9w4T8p7Edi8iKPEtX1_qZjo0Fg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox