public inbox for [email protected]
help / color / mirror / Atom feedFrom: Harshal Dhumal <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: Fix for issue RM1336 [pgadmin4]
Date: Wed, 29 Jun 2016 23:35:57 +0530
Message-ID: <CAFiP3vywwsR96uwDd-KzwF1Vc3DEaBnKWT5v4Sc6y3f-FstCGQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowW1+ezv93fdbvKtmper+jWOfs+XbgdCSMUJiH23xHQAA@mail.gmail.com>
References: <CAFiP3vxoqJ8Rd2fiXev2di1Se_WuyAZdMtUHcHG3HuHwk-vj0g@mail.gmail.com>
<CA+OCxozZz4q4Cac8sS2wZ0OprfjOKQRqmSXQjHdd=-sBoVfsbA@mail.gmail.com>
<CAFiP3vxfQ4=+zjLW9HR_dtYkbgfZLvKLnLZi-A3m4rbFH_A5xA@mail.gmail.com>
<CAFiP3vznYPXdvmGj2J7i4S7e-BPUVWWUC5KFAK=Q7n6Nee5ThA@mail.gmail.com>
<CA+OCxoza3djrtauF1VqSvqU1pXBr8gAzHD9xF1T37HbkbgEztA@mail.gmail.com>
<CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com>
<CA+OCxowGax9fd5YmTG3u82Ums0rwkETiXFQPuBokKBx_Br8BOA@mail.gmail.com>
<CAG7mmozksaXEZv=Sz-f4vkHgDjn-_5LTBzP5=wP-+RNeCMVH3Q@mail.gmail.com>
<CA+OCxoy=cO2feBinWxO8hMuUN3x9+DFeKkDZ-5hv=2NWfht-dw@mail.gmail.com>
<CAFiP3vxq4-jHf0GALVH=eaQM5d+rrdu8Z49Q1ksL4ftKUzzVyQ@mail.gmail.com>
<CA+OCxowSS8R1zh1jajhhN6ibtH4x1+w=xwY5i11_Ub7zCJ9JFQ@mail.gmail.com>
<CAMjNa7e3vkEsiRGqt6kw3Z+z6v-z6Ox4-F0VmCDJEGW2pynWOg@mail.gmail.com>
<CA+OCxoxbbVX6HZJVeXxRFhbkiG692RZx9WoWo=jmkv6gc79eRA@mail.gmail.com>
<[email protected]>
<CA+OCxowW1+ezv93fdbvKtmper+jWOfs+XbgdCSMUJiH23xHQAA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
PFA upadated patch for RM1336
Issue fixed: Query tool shortcuts weren't working on mac runtime. Also
changed shortcut key for "Explain analyze" from Ctrl+Shift+A --->
Alt+Shift+N as Ctrl+Shift+A was conflicting with shortcut to show "about"
dialog in runtime.
--
*Harshal Dhumal*
*Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jun 20, 2016 at 7:30 PM, Dave Page <[email protected]> wrote:
> On Mon, Jun 20, 2016 at 2:51 PM, Colin Beckingham <[email protected]>
> wrote:
> >
> > On 20/06/16 09:33, Dave Page wrote:
> >>
> >> It's not that it's necessarily hard, it's that there are only 24 hours
> in
> >> the day to get things done. We've got a long list of improvements to
> make -
> >> some immediate (i.e. in time for betaX - 2 being today in fact), others
> for
> >> GA and others for future releases. Meanwhile, much as I'd like to, I
> cannot
> >> keep 10 people assigned to pgAdmin indefinitely. I do need to get them
> >> working on other projects, for which there are also deadlines.
> >
> > Since pgadmin4 is at the top of the stack browser - window environment -
> OS
> > - kernel, all of which have their call on some specific set of
> shortcuts, a
> > couple of thoughts:
> > 1. are there other applications similar to pgadmin which are in the same
> > position where they too are looking for shortcuts? In which case is
> there a
> > possibility of cross-fertilization of ideas?
>
> The only app I've found so far like that is Gmail, but 95% of it's
> shortcuts are single keys that only work when you're not already
> focussed in an editable field. In pgAdmin, that doesn't help much in
> cases like this, when you're likely editing a query.
>
> > 2. in the world of software shortcuts, the needs of dependent
> applications
> > such as pgadmin might not have been foreseen, but is there in the
> hierarchy
> > a moral obligation to keep a certain subset of combinations free? At the
> > moment it seems like a free for all...
>
> Yeah, you'd think there should be some moral obligation, but you're
> right - it is a free for all.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[text/x-patch] RM1336_V2.patch (1.4K, 3-RM1336_V2.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 92579f1..4001066 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1015,19 +1015,23 @@ define(
// Callback for keyboard event
keyAction: function(ev) {
- if(ev.ctrlKey && ev.shiftKey) {
- if(ev.keyCode == 69) {
- // char e/E
- // Execute query.
- this.on_flash(ev);
- } else if(ev.keyCode == 88){
- // char x/X
- // Explain query.
- this.on_explain(ev);
- } else if(ev.keyCode == 65) {
- // char a/A
- // Explain analyze query.
- this.on_explain_analyze(ev);
+ if(ev.shiftKey) {
+ if(ev.ctrlKey) {
+ if(ev.keyCode == 69) {
+ // char e/E
+ // Execute query.
+ this.on_flash(ev);
+ } else if(ev.keyCode == 88) {
+ // char x/X
+ // Explain query.
+ this.on_explain(ev);
+ }
+ } else if(ev.altKey) {
+ if(ev.keyCode == 78) {
+ // char n/N
+ // Explain analyze query.
+ this.on_explain_analyze(ev);
+ }
}
}
}
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Fix for issue RM1336 [pgadmin4]
In-Reply-To: <CAFiP3vywwsR96uwDd-KzwF1Vc3DEaBnKWT5v4Sc6y3f-FstCGQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox