public inbox for [email protected]  

help / color / mirror / Atom feed

From: Harshal Dhumal <[email protected]>
To: Thom Brown <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: Surinder Kumar <[email protected]>
Subject: Re: [PATCH] Tables node (pgAdmin4)
Date: Sat, 7 May 2016 19:43:53 +0530
Message-ID: <CAFiP3vzDkX587zc0S_Dubf6v3Df0pBf5tcyzWefTrMYPaB=ogw@mail.gmail.com> (raw)
In-Reply-To: <CAA-aLv4z0RcdDvYLtQFH1JgWH2pdPizW9Fa+XaOSTQYQgZeLzg@mail.gmail.com>
References: <CAKKotZRCf07F_SGHi4KawBtLHPSeKz5Uvzwu6ddQ=bKc1FDRRw@mail.gmail.com>
	<CAFiP3vw61T0n--F4vYXALdtrkBKznBegBPq5Ds=6uZrg02vWXQ@mail.gmail.com>
	<CAA-aLv7fzZnxRhwV6umxhA-k52YekWyi7t1F34aPpUXR+41tjg@mail.gmail.com>
	<CAA-aLv4z0RcdDvYLtQFH1JgWH2pdPizW9Fa+XaOSTQYQgZeLzg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

i have fixed all of below mentioned issues.


> A couple more:
>


>
> If I go to create a new table, give it a name, select a table to
> inherit from, and then do nothing else, I get an error:
>
> ERROR: syntax error at or near "INHERITS"
> LINE 2: INHERITS (test)
> ^
>
> This is because no column list was provided, and in this case, an
> empty one would be needed.  So instead of:
>
> CREATE TABLE public.test2
> (
> )
>     INHERITS (test)
> WITH (
>     OIDS = FALSE
> )
> TABLESPACE pg_default;
>
> It should be:
>
> CREATE TABLE public.test2
>     INHERITS (test)
> WITH (
>     OIDS = FALSE
> )
> TABLESPACE pg_default;
>
>
> If I go to create another new table, give it a name, and then in the
> Like section on the Advance tab, I select a table, and enable each of
> the With * options, the following SQL is produced:
>
> CREATE TABLE public.test2
>     LIKE public.test
>         INCLUDING DEFAULTS
>         INCLUDING CONSTRAINTS
>         INCLUDING INDEXES
>         INCLUDING STORAGE
>         INCLUDING COMMENTSWITH (
>     OIDS = FALSE
> )
> TABLESPACE pg_default;
>
> The LIKE statement should appear in the column list section, so should
> be surrounded in parentheses.  Also, the WITH statement here is not on
> a new line.
>
> So this should be:
>
> CREATE TABLE public.test2
> (
>     LIKE public.test
>         INCLUDING DEFAULTS
>         INCLUDING CONSTRAINTS
>         INCLUDING INDEXES
>         INCLUDING STORAGE
>         INCLUDING COMMENTS
> )
> WITH (
>     OIDS = FALSE
> )
> TABLESPACE pg_default;
>
>
>

>
> Thom
>

view thread (49+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Tables node (pgAdmin4)
  In-Reply-To: <CAFiP3vzDkX587zc0S_Dubf6v3Df0pBf5tcyzWefTrMYPaB=ogw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox