public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: To fix salt generation in session.py
Date: Mon, 11 Jul 2016 16:33:09 +0530
Message-ID: <CAG7mmowMzvsgaD4X5k-oG=RDv9rESeGr2hSnmyEiR6QFbh_rDA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZQ+bG5P2Jmr-A93hmqps8AuRX=PTD69dOWmxgU9Q-ZQFg@mail.gmail.com>
References: <CAKKotZTcPrR6uWqPUSCrgObfLVwEp4ECb14tqpNPi9vJcY4+bA@mail.gmail.com>
<CAKKotZT058JHVyc=Avsz_S4f=QzoTMnQAWNXsXEm3W1BgmnGfw@mail.gmail.com>
<CAG7mmoy2PFR0PNRqa=x99ZBGCtd8c7ari+Lb7YxgzgdTGuZSNw@mail.gmail.com>
<CAKKotZQ+bG5P2Jmr-A93hmqps8AuRX=PTD69dOWmxgU9Q-ZQFg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
I've committed the patch.
Thanks for testing it.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> Tested, I'm able to login now.
>
>
> Thanks,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi Murtuza,
>>
>> Can you please test this patch for the same?
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>> On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please hold on in this patch, Need additional changes.
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> With latest pull session.py fails with below error with python3 because
>>>> in python3 strings 'lowercase' method has been renamed to
>>>> 'ascii_lowercase', PFA patch to fix the issue.
>>>>
>>>> Issue:
>>>> ----------
>>>> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign*
>>>> * self.randval =
>>>> ''.join(random.sample(string.lowercase+string.digits, 20))*
>>>> *AttributeError: module 'string' has no attribute 'lowercase'*
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: To fix salt generation in session.py
In-Reply-To: <CAG7mmowMzvsgaD4X5k-oG=RDv9rESeGr2hSnmyEiR6QFbh_rDA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox