public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Joao De Almeida Pereira <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3140] Add service parameter
Date: Tue, 13 Mar 2018 09:45:00 +0530
Message-ID: <CAG7mmowV+Nb_AjJmAu6qR0qbgv-jQTHf62CSXsFgeHgNvhjyRg@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZRvWmbGLfUWG2S4-5TAsV2TT0MoByTLYys1y2xFtkvBmg@mail.gmail.com>
References: <CAKKotZSrYHCypG0rfsD9DHCoE8-c+XAvBnU3vS8LMDfPqSrC1Q@mail.gmail.com>
<CA+OCxoy7R6TU5Z3+b-D6Oz80yBafYVMe-6AtJ3QXoK6HC3jFXw@mail.gmail.com>
<CAKKotZSt4is3xjhRbroRkuzBvGtbruGERQ2EX4dTTSvDX+3KnQ@mail.gmail.com>
<CAKKotZT5AikN+70CnVwcyDApeSPZ6Awx8YTNKoMWxHRmoVctHw@mail.gmail.com>
<CA+OCxowJVm2iPkhCJ+Zwjf=T0vjy77SawFAwxAAqZSkYJkpnug@mail.gmail.com>
<CAE+jjakfoBbkQfg0po3zvj0ScJQzrCWF2fUeuypVmBmpKh56iA@mail.gmail.com>
<CA+OCxoz3HbYUosGWQvb4JQGtQpSTAuLNFCQwQZQV=4LqFcyobg@mail.gmail.com>
<CAG7mmoy9LaFpm6kJXm_gVJ2Sijany8Jz5DZKWX8ja+dX58hMvg@mail.gmail.com>
<CAKKotZRvWmbGLfUWG2S4-5TAsV2TT0MoByTLYys1y2xFtkvBmg@mail.gmail.com>
On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Ashesh,
>
> I haven't implemented that intentionally because Khushboo is working on
> the same for SSL and our code will conflict, So once Khushboo's patch gets
> committed, I'll make changes for Service file as well.
>
No - that's a bad practice.
You need to work on full feature set, not partial.
If you have intentionally skipped that, you should have informed the list.
-- Thanks, Ashesh
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Murtuza/Dave,
>>
>> I have to reviewed/seen the patch yet.
>> But - I have a question.
>> Have we used the service file in the external tools for backup, restore,
>> and import/export functionalities?
>> If not - we should fix that asap.
>>
>> We had missed that during SSL support, and now - we're fixing that.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>> On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave and Murtuza,
>>>>
>>>> Regarding this patch we refactored the Javascript code so that is lives
>>>> in a different file and added some tests.
>>>>
>>>> Also we found an issue with karma-jasmine that does not allow us to use
>>>> jasmine 3.1 yet. You can find attached a patch that reverts that commit.
>>>>
>>>
>>> Sounds good, but neither patch will apply (in fact, the Jasmine one
>>> looks entirely backwards). One of the error messages was changed in
>>> Murtuza's patch, and wasn't reflected in your update for example.
>>>
>>> Can you rebase please?
>>>
>>> Thanks.
>>>
>>>
>>>>
>>>> Thanks
>>>> Victoria && Joao
>>>>
>>>> On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Thanks, patch applied!
>>>>>
>>>>> On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> PFA updated patch.
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I'll change the name and send you updated patch.
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> HI
>>>>>>>>
>>>>>>>> On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> PFA patch to add service parameter in server dialog.
>>>>>>>>> - Docs updated
>>>>>>>>> - Test case added for Service ID parameter
>>>>>>>>>
>>>>>>>>> Please note,
>>>>>>>>> I have extracted Connection class and Server manager class from
>>>>>>>>> our own custom Psycopg2 driver module.
>>>>>>>>>
>>>>>>>>> Patch also covers RM#3120
>>>>>>>>>
>>>>>>>>
>>>>>>>> This patch seems a little confused. The "Service" and "Service ID"
>>>>>>>> fields from pgAdmin 3 are very different things. The Redmine ticket seems
>>>>>>>> to be asking for the Service field (the pg_service.conf service name),
>>>>>>>> *not* Service ID (the operating system's service ID, used to start/stop the
>>>>>>>> database server service).
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
view thread (14+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][RM#3140] Add service parameter
In-Reply-To: <CAG7mmowV+Nb_AjJmAu6qR0qbgv-jQTHf62CSXsFgeHgNvhjyRg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox