public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][Patch]: Collection Control Fixes
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: Collection Control Fixes
@ 2016-03-28 09:22 Khushboo Vashi <[email protected]>
  2016-04-01 09:57 ` Re: [pgAdmin4][Patch]: Collection Control Fixes Ashesh Vashi <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Khushboo Vashi @ 2016-03-28 09:22 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find attached patch to fix below issues in the Collection Control:

1> Unique Collection Control:
Couldn't listen Change event
2> Subnode Collection Control:
Add button Label was not in Upper case

First Issue was reported by Murtuza.

Thanks,
Khushboo


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [text/x-patch] pgAdmin4_collection_control_fixes.patch (1.2K, 3-pgAdmin4_collection_control_fixes.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 60a93ac..e30a278 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -899,7 +899,7 @@
     },
     render: function() {
       // Clean up existing elements
-      this.cleanup();
+      this.undelegateEvents();
 
       var field = _.defaults(this.field.toJSON(), this.defaults),
           attributes = this.model.toJSON(),
@@ -945,6 +945,7 @@
       this.$el.html(grid).addClass(field.name);
       this.updateInvalid();
 
+      this.delegateEvents();
       return this;
     },
     showGridControl: function(data) {
@@ -1169,7 +1170,7 @@
     showGridControl: function(data) {
       var gridHeader = ["<div class='subnode-header'>",
           "  <label class='control-label col-sm-4'>" + data.label + "</label>" ,
-          "  <button class='btn-sm btn-default add'>Add</buttton>",
+          "  <button class='btn-sm btn-default add'>ADD</buttton>",
           "</div>"].join("\n");
         gridBody = $("<div class='pgadmin-control-group backgrid form-group col-xs-12 object subnode'></div>").append(gridHeader);
 


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][Patch]: Collection Control Fixes
  2016-03-28 09:22 [pgAdmin4][Patch]: Collection Control Fixes Khushboo Vashi <[email protected]>
@ 2016-04-01 09:57 ` Ashesh Vashi <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Ashesh Vashi @ 2016-04-01 09:57 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Mon, Mar 28, 2016 at 2:52 PM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find attached patch to fix below issues in the Collection Control:
>
> 1> Unique Collection Control:
> Couldn't listen Change event
> 2> Subnode Collection Control:
> Add button Label was not in Upper case
>
> First Issue was reported by Murtuza.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-04-01 09:57 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-03-28 09:22 [pgAdmin4][Patch]: Collection Control Fixes Khushboo Vashi <[email protected]>
2016-04-01 09:57 ` Ashesh Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox