public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: pgAgent support
Date: Fri, 23 Sep 2016 12:03:04 +0530
Message-ID: <CAG7mmoxtquaN=ZcC6F6xm_-LrrVMyw2JQx-WgNV6YErPDYBdUg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozmX2ZVYG9ors8XVisMMvf1uf4FL8Rx=ATuCiJv9RyVFQ@mail.gmail.com>
References: <CAG7mmozpAhowsCTTs1nCqxJ=VCGS42-v=py-Ev-pXoSCFzSOMg@mail.gmail.com>
<CA+OCxozmX2ZVYG9ors8XVisMMvf1uf4FL8Rx=ATuCiJv9RyVFQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
On Thu, Sep 22, 2016 at 8:01 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Sep 22, 2016 at 11:47 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Please find the patch for support for paAgent in pgAdmin 4.
>>
>
> Did you forget the binary switch?
>
> piranha:web dpage$ git apply --binary ~/Downloads/pgagent_v2.patch
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/schedules/static/img/coll-pga_schedule.png'
> without full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/coll-pga_schedule.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/schedules/static/img/pga_schedule.png' without
> full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/
> schedules/static/img/pga_schedule.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/coll-pga_job.png' without full index
> line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/coll-pga_job.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/pga_job-disabled.png' without full
> index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job-disabled.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/static/img/pga_job.png' without full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/static/img/pga_job.png:
> patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/steps/static/img/coll-pga_jobstep.png' without
> full index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/
> static/img/coll-pga_jobstep.png: patch does not apply
> error: cannot apply binary patch to 'web/pgadmin/browser/server_
> groups/servers/pgAgent/steps/static/img/pga_jobstep.png' without full
> index line
> error: web/pgadmin/browser/server_groups/servers/pgAgent/steps/static/img/pga_jobstep.png:
> patch does not apply
>
>>
>> I have also attached another patch for miscellaneous fixes, and adding
>> new controls.
>> It includes:
>> - Added DatetimepickerControl, MomentCell (using moment.js)
>> - Used the 'DatetimepickerControl' in Role (Also - resolved an issue,
>> when unset the datetime for 'Valid Until'.)
>> - Added a 'Select All/Unselect All' adaptor for Select2 used by pgAgent
>> nodes.
>> - Fixed an issue with SubNodeCollectionControl, which was not starting
>> the modification session of the child model, when created default value for
>> collection is not null/undefined. And, hence - validation on the child
>> model was not working.
>> - Fixed a memory leak with SqlFieldControl, and SqlTabControl, which was
>> not releasing the CodeMirror properly.
>>
>
> Urgh, that's big.
>
I know.
That's reason - I was reluctant to send earlier.
> Applied - but can you look at the following please?
>
> - Account expires has a hint of 'MMM D YYYY HH:mm:ss.SSS Z". Are
> milliseconds really needed? I also get 00 as a fractional timezone offset.
> Perhaps we should hide that, when it's 00?
>
Changed to 'YYYY-MM-DD HH:mm:ss Z'.
>
> - The date format differs from the ISO format displayed by the query tool.
> They should be consistent - and really should be either based on the
> client's locale settings, or ISO format.
>
Done
--
Thanks & Regards,
Ashesh Vashi
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] rolvaliduntil_format.patch (924B, 3-rolvaliduntil_format.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
index c02ba88..e6574c5 100644
--- a/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
+++ b/web/pgadmin/browser/server_groups/servers/roles/templates/role/js/role.js
@@ -406,7 +406,7 @@ function($, _, S, pgAdmin, pgBrowser, alertify, Backform) {
id: 'rolvaliduntil', disabled: 'readonly', type: 'text',
group: '{{ _('Definition') }}', label: '{{ _('Account expires') }}',
mode: ['properties', 'edit', 'create'], control: 'datetimepicker',
- deps: ['rolcanlogin']
+ deps: ['rolcanlogin'], options: {format: 'YYYY-MM-DD HH:mm:ss Z'}
},{
id: 'rolconnlimit', type: 'int', group: '{{ _('Definition') }}',
label: '{{ _('Connection limit') }}', cell: 'number',
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: pgAgent support
In-Reply-To: <CAG7mmoxtquaN=ZcC6F6xm_-LrrVMyw2JQx-WgNV6YErPDYBdUg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox