public inbox for [email protected]  
help / color / mirror / Atom feed
From: Ashesh Vashi <[email protected]>
To: Dave Page <[email protected]>
Cc: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgagent job failing to halt on failed step
Date: Tue, 1 Dec 2015 15:46:00 +0530
Message-ID: <CAG7mmoz=s51E0_ec70b2xswEnWHA6VojPrqi28fC7nn4TFV3Lg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozDyW6WLXCcosQQcs3zdL_aEn_xJRFc9WeY3kAzZGoEhQ@mail.gmail.com>
References: <CA+yw=mP_qCXAoxwpPLWh81_9h=9FyX869=pF68mL9RA-6=oJfw@mail.gmail.com>
	<CA+OCxozDyW6WLXCcosQQcs3zdL_aEn_xJRFc9WeY3kAzZGoEhQ@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Yes.


--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;


*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;

On Tue, Dec 1, 2015 at 2:52 PM, Dave Page <[email protected]> wrote:

> This is what you just committed right Ashesh?
>
> On Tue, Dec 1, 2015 at 5:36 AM, Sanket Mehta
> <[email protected]> wrote:
> >
> > Hi,
> >
> > There is an issue in current pgagent code as explained below:
> >
> > Issue:
> > In batch mode if user creates a job with multiple job steps then if first
> > jobstep gets executed successfully then even if 2nd step is a failure,
> job
> > will not halt at that point and will complete its execution. which is not
> > the expected result.
> >
> > Analysis:
> > The main reason for this issue is that in batch mode, when first step is
> > executed successfully, flag succeeded will be set to true, but when the
> 2nd
> > step gets failed, its not getting reset to false which is why job does
> not
> > halt at the same instance and continues executing next steps.
> >
> > I have resolved this issue and patch is attached with this mail for
> review.
> > Please do review the patch and let me know in case anything is missing.
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list ([email protected])
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgagent job failing to halt on failed step
  In-Reply-To: <CAG7mmoz=s51E0_ec70b2xswEnWHA6VojPrqi28fC7nn4TFV3Lg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox