public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Neel Patel <[email protected]>
Cc: Mehmet Emin KARAKAŞ <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PgAgent leap year problem
Date: Wed, 4 Mar 2020 13:22:31 +0530
Message-ID: <CAG7mmozJSWMDG9wBfbhcKj6=3F_tG0uZF3=ukq+csCP3-frn7A@mail.gmail.com> (raw)
In-Reply-To: <CACCA4P1U9VgYde+G5VHhpa0dRjuJW619u5-QhFTGpWW7hXnUvQ@mail.gmail.com>
References: <CANQrdXBzJNK+_tDgju_qTq-OuG7dKdqNZ6Xv=-n0-RoYM0PXhA@mail.gmail.com>
<CACCA4P2A=t9UcKYyiB3-Z0J3zNQNsa48UwWrwUJ90koTxNL99g@mail.gmail.com>
<CAG7mmow0UvptW972pfHM3yJs+NDLpdv8E9Bw7GGdBOKed=Kokw@mail.gmail.com>
<CACCA4P1U9VgYde+G5VHhpa0dRjuJW619u5-QhFTGpWW7hXnUvQ@mail.gmail.com>
On Wed, Mar 4, 2020 at 12:36 PM Neel Patel <[email protected]>
wrote:
> Hi Ashesh,
>
> I have reviewed it and looks good. I have updated the sql version in
> header of each sql file.
>
Thanks Neel.
Committed the patch with the change suggested offline regarding the updated
version in the windows resource (.rc) files.
-- Thanks, Ashesh
>
> Thanks,
> Neel Patel
>
> On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi <
> [email protected]> wrote:
>
>> On Wed, Mar 4, 2020 at 10:53 AM Neel Patel <[email protected]>
>> wrote:
>>
>>> Hi Mehmet,
>>>
>>> It was a bug in pgAgent. Thank you for sharing the patch. I have
>>> reviewed and tested, it is working fine.
>>>
>>> Dave/Ashesh:- Can we commit this patch ?
>>>
>> Mehmet,
>>
>> Thanks for your patch.
>> Changes look good except it does not take care of the upgrade scenarios.
>>
>> Hence - updated the patch for the same.
>>
>> Neel,
>>
>> Would you please review the updated patch with the upgrade scenarios?
>>
>>
>> -- Thanks, Ashesh
>>
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>> On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> Scheduled tasks set as the last day of February this year did not work.
>>>> In your schedule function have a small bug. Leap year function get year
>>>> parameter, but your code is sending day as a parameter. Fixing patch
>>>> attached in this mail.
>>>>
>>>> Best Regards...
>>>>
>>>> --
>>>> MEHMET EMİN KARAKAŞ
>>>> PostgreSQL DBA
>>>>
>>>> Turksat Satellite Communication and Cable TV Operations
>>>> Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
>>>> Tel : +90 312 615 32 73
>>>> Faks : +90 312 615 32 77
>>>>
>>>
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: PgAgent leap year problem
In-Reply-To: <CAG7mmozJSWMDG9wBfbhcKj6=3F_tG0uZF3=ukq+csCP3-frn7A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox