public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: Backgrid StringDepsCell
Date: Tue, 10 May 2016 12:42:31 +0530
Message-ID: <CAG7mmozvADq2hyZiaJPpQej=F--8qJ1vonPZKdsqzSwUgE0ThQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELe8DXstkb22f7Wp7dfLvSYC8fB5_B4B10WOz-UXzxjiFQ@mail.gmail.com>
References: <CAFOhELcoJTEm=V=buZKdt_Eoc1ur4jGySg6J3BdKpNn5aVVhuw@mail.gmail.com>
<CAG7mmozs_bVt0qRqQZiD42HjAAFFZ6LT6j5tn_UbZ=aWvfptGA@mail.gmail.com>
<CAFOhELcZpPHsuV9KgCmwSypp=Q9Qr0kXb=cs4=8eU=h20YGVZg@mail.gmail.com>
<CAFOhELcYc3OAX+Wr-C0hQpthWPx7O9G7ebAdR839L-7v9GJXew@mail.gmail.com>
<CAG7mmoyxA81f0EhgwCqesFTD4=nQGeZF+XUDDPv+2Og1QKDyFg@mail.gmail.com>
<CAFOhELe8DXstkb22f7Wp7dfLvSYC8fB5_B4B10WOz-UXzxjiFQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks - committed!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Mon, May 9, 2016 at 12:26 PM, Khushboo Vashi <
[email protected]> wrote:
> Hi,
>
> Please find the attached re-based patch.
>
> Thanks,
> Khushboo
>
> On Wed, Apr 6, 2016 at 2:38 PM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi Khushboo,
>>
>>
>> On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi Ashesh,
>>>
>>> I have changed the function name (from *render_deps* to *updateUIDeps*),
>>> which will be called on the dependent field change, as per your suggestion.
>>>
>> I've updated the patch.
>> Please try this.
>> I think - 'updateUIDeps' is not the write name.
>> A Cell can do anything, when dependent changed, hence - I renamed it with
>> 'dependentChanged'.
>>
>> Also, The user is not going to extend existing cell from the
>> DependendsCell, but - only going to use the functions.
>> Hence - I have created a separate class for it instead of extend it from
>> Backgrid.Cell.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>>>
>>> Please find attached patch for the same.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi Ashesh,
>>>>
>>>> Yes, agreed. This implementation limits us to use only String Cell.
>>>> So, I have modified the patch as you suggested.
>>>>
>>>> Please find the attachment for the same.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Fri, Apr 1, 2016 at 2:59 PM, Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> I am reluctant to use this code as it is.
>>>>> I would prefer you create just helper functions (i.e. initialize,
>>>>> remove) for the dependents in Backgrid.Cell, and then use them directly
>>>>> from the different cell itself.
>>>>> Because - this functionality limits us to us only with the string type.
>>>>>
>>>>> Anyway - we will be using the dependent functionality for very
>>>>> attributes.
>>>>>
>>>>>
>>>>> You can extend them directly in the Node's model (schema).
>>>>>
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>> <http://www.enterprisedb.com;
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>
>>>>> On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch for the Backgrid *StringDepsCell.*
>>>>>>
>>>>>> The *StringDepsCell* displays HTML escaped strings and accepts anything typed in.
>>>>>> Also, Listen to the dependent fields.
>>>>>>
>>>>>>
>>>>>> Usage of the Backgrid Cell:
>>>>>>
>>>>>> If the Precision cell is dependent on the Datatype then:
>>>>>>
>>>>>> {
>>>>>> id: 'precision', label:'{{ _('Precision') }}', type: 'test'
>>>>>> cell: *Backgrid.Extension.StringDepsCell*, deps: ['datatype']
>>>>>>
>>>>>> }
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sent via pgadmin-hackers mailing list ([email protected]
>>>>>> )
>>>>>> To make changes to your subscription:
>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: Backgrid StringDepsCell
In-Reply-To: <CAG7mmozvADq2hyZiaJPpQej=F--8qJ1vonPZKdsqzSwUgE0ThQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox