public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashesh Vashi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields
Date: Wed, 30 Jan 2019 15:22:22 +0530
Message-ID: <CAG7mmozxGpBmNPX4sQE9y2Rs4c5=oKduL0WhG3i9wBoWmYdusQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELfmEc-n055g0D5WG4G6zVdVSWoihhVsONJ5GvLSjCwp3w@mail.gmail.com>
References: <CAFOhELfosrL2Y_2_gwHyzef5JeSSzNSyicSNj6uv1B1286yKzg@mail.gmail.com>
<CANxoLDc1q3KmpmO=SZw69J9on-TUUBVj-QoN7aYAtgYjP3HBsQ@mail.gmail.com>
<CAM9w-_=RLYvwz4HJ5YrDPSdX80B7kLvt0Ti41F6r0_deAt-wHg@mail.gmail.com>
<CAFOhELe+UJqC-4vyBe2yk_Mz27DKfJFFyU1UbURZ9ycrQs9SYA@mail.gmail.com>
<CAKKotZShgdVkCqaQ6JFG9cyLd=r5D8xTWK0JgFqncFWV6x+j+Q@mail.gmail.com>
<CAG7mmozPL4-=CD=DMN=sUkSKpFKKL-jJEP+L=90+VyOjJ3baww@mail.gmail.com>
<CAFOhELfmEc-n055g0D5WG4G6zVdVSWoihhVsONJ5GvLSjCwp3w@mail.gmail.com>
On Wed, Jan 30, 2019 at 3:17 PM Khushboo Vashi <
[email protected]> wrote:
> Hi All,
>
> As per our discussion, I have implemented the CSS Switch. Reference:
> https://codepen.io/personable/pen/stpwD?editors=1100#0
> Please find the attached patch for the same.
>
> Please check the performance for the Login/Group roles Properties tab.
>
Do you see any performance benefit with the CSS approach?
-- Thanks, Ashesh
>
> Thanks,
> Khushboo
>
>
>
>
> On Tue, Jan 29, 2019 at 10:47 AM Ashesh Vashi <
> [email protected]> wrote:
>
>> On Tue, Jan 29, 2019 at 10:39 AM Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> On Tue, Jan 29, 2019 at 9:43 AM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi Aditya,
>>>>
>>>> Thanks for the review.
>>>>
>>>> Please find the attached updated patch.
>>>>
>>>> @ Murtuza,
>>>>
>>>> Regarding your concern, I have not used the API. As per the
>>>> documentation, there are 2 ways to initialise the bootstrap toggle, First
>>>> Initialise with HTML and second with Code.
>>>> In our case, Initialisation with HTML is not possible as we render the
>>>> backform controls runtime, So, I have used the other option.
>>>> Also, the main issue of slow rendering which has been solved through
>>>> this implementation. The browser hanging issue is due to Backbone
>>>> collection reset method and I am working on that part with another RM,
>>>> https://redmine.postgresql.org/issues/3664.
>>>>
>>>
>>> I agreed to that, that's why I wrote when not in edit mode : )
>>>
>>> With API mode, we are performing DOM operation on each individual
>>> instance (specially in Subnode/Backgrid) which I think we should avoid when
>>> we are just displaying to the user.
>>>
>> I agree - it was my concern with the earlier switch control as well.
>>
>> I was thinking of using switch control based on complete CSS.
>> How about the following?
>> https://github.com/ghinda/css-toggle-switch
>> https://ghinda.net/css-toggle-switch/bootstrap.html
>>
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com/;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>>>
>>> Regrads,
>>> Murtuza
>>>
>>>>
>>>> @ Dave,
>>>>
>>>> Please, review this patch, we need your approval for the toggle design
>>>> changes.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>>
>>>>
>>>> On Tue, Jan 22, 2019 at 11:33 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> I have few suggestions/review:
>>>>> 1) Do we need to add "editor" class to switch control in backgrid when
>>>>> changing. For eg. in tables->columns if I change not null switch, it adds
>>>>> editor class which makes hover background white. Plus, leaving the switch
>>>>> does not remove editor class. I think we can skip adding editor, what
>>>>> do you think?
>>>>>
>>>> This issue was old, not due to my patch but I have fixed it.
>>>>
>>>>> 2) In Login roles, Create trigger dialogs switch control colors are
>>>>> different. Below is screenshot,
>>>>> [image: Screenshot 2019-01-22 at 11.04.36 AM.png]
>>>>>
>>>> Fixed
>>>>
>>>>> 3) In Create cast dialog switch control is smaller and so clipping
>>>>> text. Below is screenshot,
>>>>> [image: Screenshot 2019-01-22 at 11.07.14 AM.png]
>>>>>
>>>> Fixed
>>>>
>>>>> 4) You've removed unnecessary switch control template codes at most
>>>>> places. I would suggest doing the same for Backform.CustomSwitchControl in
>>>>> trigger.js
>>>>>
>>>> Done
>>>>
>>>>> 5) Feature tests are still using bootstrap-switch classes and so
>>>>> failing.
>>>>>
>>>> Fixed
>>>>
>>>>>
>>>>> Apart from above, everything looks good to me.
>>>>>
>>>>>
>>>>> On Mon, Jan 21, 2019 at 4:42 PM Akshay Joshi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Aditya
>>>>>>
>>>>>> Can you please review it.
>>>>>>
>>>>>> On Mon, Jan 14, 2019 at 4:28 PM Khushboo Vashi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Please find the attached patch to fix #3051 - Tables > Properties >
>>>>>>> Columns tab is slow on tables with a lot of fields
>>>>>>>
>>>>>>> The root cause of the issue is bootstrap switch, which has been
>>>>>>> replaced with bootstrap4-toggle application wide.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Khushboo
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Akshay Joshi*
>>>>>>
>>>>>> *Sr. Software Architect *
>>>>>>
>>>>>>
>>>>>>
>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>> Aditya Toshniwal
>>>>> Software Engineer | EnterpriseDB Software Solutions | Pune
>>>>> "Don't Complain about Heat, Plant a tree"
>>>>>
>>>>
Attachments:
[image/png] Screenshot 2019-01-22 at 11.04.36 AM.png (107.2K, 3-Screenshot%202019-01-22%20at%2011.04.36%20AM.png)
download | view image
[image/png] Screenshot 2019-01-22 at 11.07.14 AM.png (49.9K, 4-Screenshot%202019-01-22%20at%2011.07.14%20AM.png)
download | view image
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields
In-Reply-To: <CAG7mmozxGpBmNPX4sQE9y2Rs4c5=oKduL0WhG3i9wBoWmYdusQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox