public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.
Date: Fri, 9 Oct 2020 15:18:21 +0530
Message-ID: <CAJ9T6StfSregDi575XeiPNHXky=8qA4jFNtMgyLqhu2i6Zc=Jg@mail.gmail.com> (raw)
Hi Hackers,
Attached is a patch for RM5853. 'Rows X' column values were not visible
properly in Explain Analyze in the Dark and High contrast theme.
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM5853.patch (2.1K, 3-RM5853.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/scss/_explain.scss b/web/pgadmin/misc/static/explain/scss/_explain.scss
index 7c06f8c71..095372ec5 100644
--- a/web/pgadmin/misc/static/explain/scss/_explain.scss
+++ b/web/pgadmin/misc/static/explain/scss/_explain.scss
@@ -48,6 +48,7 @@ div.tab-pane[data-explain-tabpanel=table] {
td.pga-ex-inclusive-2,
td.pga-ex-rowsx-2 {
background-color: $explain-sev-2-bg;
+ color: $explain-sev-2-color;
}
td.pga-ex-exclusive-3,
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 456f45503..3814391ab 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -258,6 +258,7 @@ $sql-bracket-match-bg: #f5d2af;
$explain-sev-2-bg: #FFEE88 !default;
$explain-sev-3-bg: #EE8800 !default;
$explain-sev-4-bg: #880000 !default;
+$explain-sev-2-color: #222222 !default;
$explain-sev-3-color: #FFFFFF !default;
$explain-sev-4-color: #FFFFFF !default;
diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
index 7b2608a5b..76cee405d 100644
--- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
@@ -84,6 +84,7 @@ $explain-sev-3-bg: #824d18;
$explain-sev-4-bg: #880000;
$explain-sev-3-color: $color-fg;
$explain-sev-4-color: $color-fg;
+$explain-sev-2-color: #212529;
$negative-bg: $color-bg;
diff --git a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
index 9e447ec66..2bf2cc0db 100644
--- a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
@@ -105,6 +105,7 @@ $table-bg: $color-bg;
$explain-sev-2-bg: #EAEA43;
$explain-sev-3-bg: #FFAD65;
$explain-sev-4-bg: #EE7A55;
+$explain-sev-2-color: #010B15;
$explain-sev-3-color: #010B15;
$explain-sev-4-color: #010B15;
view thread (2+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.
In-Reply-To: <CAJ9T6StfSregDi575XeiPNHXky=8qA4jFNtMgyLqhu2i6Zc=Jg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox