public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.
@ 2020-10-09 09:48 Pradip Parkale <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Pradip Parkale @ 2020-10-09 09:48 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is a patch for RM5853. 'Rows X' column values were not visible
properly in Explain Analyze in the Dark and High contrast theme.
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM5853.patch (2.1K, 3-RM5853.patch)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/scss/_explain.scss b/web/pgadmin/misc/static/explain/scss/_explain.scss
index 7c06f8c71..095372ec5 100644
--- a/web/pgadmin/misc/static/explain/scss/_explain.scss
+++ b/web/pgadmin/misc/static/explain/scss/_explain.scss
@@ -48,6 +48,7 @@ div.tab-pane[data-explain-tabpanel=table] {
td.pga-ex-inclusive-2,
td.pga-ex-rowsx-2 {
background-color: $explain-sev-2-bg;
+ color: $explain-sev-2-color;
}
td.pga-ex-exclusive-3,
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 456f45503..3814391ab 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -258,6 +258,7 @@ $sql-bracket-match-bg: #f5d2af;
$explain-sev-2-bg: #FFEE88 !default;
$explain-sev-3-bg: #EE8800 !default;
$explain-sev-4-bg: #880000 !default;
+$explain-sev-2-color: #222222 !default;
$explain-sev-3-color: #FFFFFF !default;
$explain-sev-4-color: #FFFFFF !default;
diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
index 7b2608a5b..76cee405d 100644
--- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss
@@ -84,6 +84,7 @@ $explain-sev-3-bg: #824d18;
$explain-sev-4-bg: #880000;
$explain-sev-3-color: $color-fg;
$explain-sev-4-color: $color-fg;
+$explain-sev-2-color: #212529;
$negative-bg: $color-bg;
diff --git a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
index 9e447ec66..2bf2cc0db 100644
--- a/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
+++ b/web/pgadmin/static/scss/resources/high_contrast/_theme.variables.scss
@@ -105,6 +105,7 @@ $table-bg: $color-bg;
$explain-sev-2-bg: #EAEA43;
$explain-sev-3-bg: #FFAD65;
$explain-sev-4-bg: #EE7A55;
+$explain-sev-2-color: #010B15;
$explain-sev-3-color: #010B15;
$explain-sev-4-color: #010B15;
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.
@ 2020-10-09 12:53 Akshay Joshi <[email protected]>
parent: Pradip Parkale <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2020-10-09 12:53 UTC (permalink / raw)
To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Fri, Oct 9, 2020 at 3:18 PM Pradip Parkale <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is a patch for RM5853. 'Rows X' column values were not visible
> properly in Explain Analyze in the Dark and High contrast theme.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2020-10-09 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 09:48 [pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme. Pradip Parkale <[email protected]>
2020-10-09 12:53 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox