public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.
Date: Mon, 15 Feb 2021 18:26:47 +0530
Message-ID: <CAJ9T6StkTvBDRTb9Q07c5rS1MvYwSgN4O685XduT3iSi4egTCg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcBD0-waf_m3wfwBGJQp6ZHoHu=oxZqkn6ptJcentdWMA@mail.gmail.com>
References: <CAJ9T6Ss--gC0W-uRKj0BTr2+CWQYMGT3KB4iYv22yijSANdjmg@mail.gmail.com>
<CANxoLDedjgukXi-nEooKGF-MW5WidaEYBWmHKz2o+092GCKPkw@mail.gmail.com>
<CAJ9T6SvAtgMaeKWSyeJUmgkeoPLEQ12sTk0m0HjL8QwZmBfdDQ@mail.gmail.com>
<CANxoLDcBD0-waf_m3wfwBGJQp6ZHoHu=oxZqkn6ptJcentdWMA@mail.gmail.com>
Hi Akshay,
Please find the attached patch for API failure.
On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch.
>>
>> On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Pradip
>>>
>>> I haven't started reviewing your patch but seems you haven't written
>>> test cases for schema diff. Please add and then submit the patch again.
>>>
>>> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch for publication and subscription support
>>>> in Schema Diff.
>>>>
>>>> Also, added the dependencies for publication and subscription.
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] API_failure.patch (1.8K, 3-API_failure.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/default/dependencies.sql b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/default/dependencies.sql
new file mode 100644
index 000000000..a71f0cd25
--- /dev/null
+++ b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/default/dependencies.sql
@@ -0,0 +1,2 @@
+SELECT subpublications AS pub FROM pg_subscription
+WHERE subname = '{{subname}}';
diff --git a/web/pgadmin/tools/schema_diff/tests/pg/12_plus/source.sql b/web/pgadmin/tools/schema_diff/tests/pg/12_plus/source.sql
index d175de6ad..9f1c993fe 100644
--- a/web/pgadmin/tools/schema_diff/tests/pg/12_plus/source.sql
+++ b/web/pgadmin/tools/schema_diff/tests/pg/12_plus/source.sql
@@ -1138,9 +1138,6 @@ CREATE PUBLICATION with_one_table_in_target
FOR TABLE test_schema_diff.table_for_publication_in_target
WITH (publish = 'insert, delete');
-ALTER PUBLICATION with_one_table_in_target
- OWNER TO managers;
-
ALTER PUBLICATION with_one_table_in_target
RENAME TO with_one_table_in_target_alter;
diff --git a/web/pgadmin/tools/schema_diff/tests/pg/12_plus/target.sql b/web/pgadmin/tools/schema_diff/tests/pg/12_plus/target.sql
index 9554a5fad..40b9b4a7f 100644
--- a/web/pgadmin/tools/schema_diff/tests/pg/12_plus/target.sql
+++ b/web/pgadmin/tools/schema_diff/tests/pg/12_plus/target.sql
@@ -1069,9 +1069,6 @@ CREATE PUBLICATION with_one_table_in_target
FOR TABLE test_schema_diff.table_for_publication_in_target
WITH (publish = 'insert, delete');
-ALTER PUBLICATION with_one_table_in_target
- OWNER TO managers;
-
ALTER PUBLICATION with_one_table_in_target
RENAME TO with_one_table_in_target_alter;
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.
In-Reply-To: <CAJ9T6StkTvBDRTb9Q07c5rS1MvYwSgN4O685XduT3iSi4egTCg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox