public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Date: Wed, 19 Feb 2020 17:04:13 +0530
Message-ID: <CAJ9T6Su8cJBL4khVrE1h4U8d0EAyiadLyseFaoKEtJ6-tJ_rgA@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmoy5TCYNYPcD31FG=-jHzRJG7pdiNrFVXsFnVNKY+Qp8VQ@mail.gmail.com>
References: <CAJ9T6SsEuKBVz35pA0X+G7u6Z0JcV8ZAHB46kRD1PiovmJrhpg@mail.gmail.com>
<CAG7mmoy5TCYNYPcD31FG=-jHzRJG7pdiNrFVXsFnVNKY+Qp8VQ@mail.gmail.com>
Please find the attached patch.
On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <[email protected]>
wrote:
> Forgot to attach the patch?
>
> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is a patch for accessibility issue related Alertifyjs.
>>
>> 1. Added hidden label to satisfy accessibility.
>> 2. Added label with sr-only class.
>> 3. Added tabindex to move the mouse control to the maximize button
>> using the tab key.
>>
>>
>> Please note that this patch also includes the fix for the
>> RM-5143 Accessibility issue to maximize the panel for backup and restore
>> windows and all other places.
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> QMG, EnterpriseDB Corporation
>>
> --
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM5154.patch (2.0K, 3-RM5154.patch)
download | inline diff:
diff --git a/web/package.json b/web/package.json
index acfcb2efa..8416c5f22 100644
--- a/web/package.json
+++ b/web/package.json
@@ -51,7 +51,7 @@
},
"dependencies": {
"acitree": "git+https://github.com/imsurinder90/jquery-aciTree.git#rc.7",
- "alertifyjs": "1.7.1",
+ "alertifyjs": "git+https://github.com/pradipparkale269/AlertifyJS.git#EDB-MASTER",
"axios": "^0.18.1",
"babel-plugin-transform-es2015-modules-amd": "^6.24.1",
"babel-preset-es2015-without-strict": "~0.0.4",
diff --git a/web/pgadmin/static/js/alertify/dialog_wrapper.js b/web/pgadmin/static/js/alertify/dialog_wrapper.js
index 83186e710..876dafa77 100644
--- a/web/pgadmin/static/js/alertify/dialog_wrapper.js
+++ b/web/pgadmin/static/js/alertify/dialog_wrapper.js
@@ -64,7 +64,7 @@ export class DialogWrapper {
$(alertifyDialog.elements.footer).on('keydown', 'button', function(event) {
if (event.keyCode == 9 && $(this).nextAll('button:not([disabled])').length == 0) {
// set focus back to first editable input element of current active tab once we cycle through all enabled buttons.
- commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content div.active'));
+ $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();
return false;
}
});
diff --git a/web/yarn.lock b/web/yarn.lock
index 26272668b..62af24928 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -910,10 +910,9 @@ ajv@^6.1.0, ajv@^6.10.2, ajv@^6.9.1:
json-schema-traverse "^0.4.1"
uri-js "^4.2.2"
[email protected]:
+"alertifyjs@git+https://github.com/pradipparkale269/AlertifyJS.git#EDB-MASTER":
version "1.7.1"
- resolved "https://registry.yarnpkg.com/alertifyjs/-/alertifyjs-1.7.1.tgz#3c7b8ac67609aea737fe8e06d7fac885ce18ba8f"
- integrity sha1-PHuKxnYJrqc3/o4G1/rIhc4Yuo8=
+ resolved "git+https://github.com/pradipparkale269/AlertifyJS.git#215378e6cb5aabad9a855d3a5a1e4ad7111a6e5e"
alphanum-sort@^1.0.0:
version "1.0.2"
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
In-Reply-To: <CAJ9T6Su8cJBL4khVrE1h4U8d0EAyiadLyseFaoKEtJ6-tJ_rgA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox