public inbox for [email protected]  
help / color / mirror / Atom feed
From: Pradip Parkale <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data
Date: Tue, 27 Oct 2020 15:26:00 +0530
Message-ID: <CAJ9T6Svb=K4O5cVbeFkkrTsgiKX2rJvfWr=b7EL-Xz7+ymaoSg@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached for RM4061. Backslashes were not handled
correctly for SQL_ASCII database.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


Attachments:

  [application/octet-stream] RM4061.patch (664B, 3-RM4061.patch)
  download | inline diff:
diff --git a/web/pgadmin/utils/driver/psycopg2/typecast.py b/web/pgadmin/utils/driver/psycopg2/typecast.py
index 8a10d8c75..31d043d71 100644
--- a/web/pgadmin/utils/driver/psycopg2/typecast.py
+++ b/web/pgadmin/utils/driver/psycopg2/typecast.py
@@ -187,7 +187,7 @@ def register_string_typecasters(connection):
                 return None
             return bytes(
                 value, encodings[cursor.connection.encoding]
-            ).decode(typecast_encoding, errors='replace')
+            ).decode(python_encoding, errors='replace')
 
         unicode_type = psycopg2.extensions.new_type(
             # "char", name, text, character, character varying


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data
  In-Reply-To: <CAJ9T6Svb=K4O5cVbeFkkrTsgiKX2rJvfWr=b7EL-Xz7+ymaoSg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox