public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data
@ 2020-10-27 09:56  Pradip Parkale <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Pradip Parkale @ 2020-10-27 09:56 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Hackers,

Please find the attached for RM4061. Backslashes were not handled
correctly for SQL_ASCII database.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


Attachments:

  [application/octet-stream] RM4061.patch (664B, 3-RM4061.patch)
  download | inline diff:
diff --git a/web/pgadmin/utils/driver/psycopg2/typecast.py b/web/pgadmin/utils/driver/psycopg2/typecast.py
index 8a10d8c75..31d043d71 100644
--- a/web/pgadmin/utils/driver/psycopg2/typecast.py
+++ b/web/pgadmin/utils/driver/psycopg2/typecast.py
@@ -187,7 +187,7 @@ def register_string_typecasters(connection):
                 return None
             return bytes(
                 value, encodings[cursor.connection.encoding]
-            ).decode(typecast_encoding, errors='replace')
+            ).decode(python_encoding, errors='replace')
 
         unicode_type = psycopg2.extensions.new_type(
             # "char", name, text, character, character varying


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data
@ 2020-10-28 09:32  Khushboo Vashi <[email protected]>
  parent: Pradip Parkale <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Khushboo Vashi @ 2020-10-28 09:32 UTC (permalink / raw)
  To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers

Hi Pradip,

With this patch, 4061 is getting fixed but if you enter "zażółć", then it
is getting displayed as "zaż\xf3łć". So, the fix is not proper.

Also, if you want to change the typecast, then change the dict which is
mapped for Postgres, Python and Typecast encoding in encoding.py file.

Thanks,
Khushboo



On Tue, Oct 27, 2020 at 3:26 PM Pradip Parkale <
[email protected]> wrote:

> Hi Hackers,
>
> Please find the attached for RM4061. Backslashes were not handled
> correctly for SQL_ASCII database.
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2020-10-28 09:32 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 09:56 [pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data Pradip Parkale <[email protected]>
2020-10-28 09:32 ` Khushboo Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox