public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals
3+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals
@ 2021-03-08 16:37 Pradip Parkale <[email protected]>
2021-03-09 10:52 ` Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Pradip Parkale <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Pradip Parkale @ 2021-03-08 16:37 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please find attached the patch for RM4784.
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM-4784.patch (1.0K, 3-RM-4784.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
index 03fd7d6e1..8eaad6843 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
@@ -213,6 +213,7 @@ define('pgadmin.node.schema', [
cellFunction: Backform.cellFunction, editable: function(m) {
return m.handler.get('autovacuum_custom');
}, headerCell: Backgrid.Extension.CustomHeaderCell,
+ formatter:Backgrid.CellFormatter,
},
{
name: 'setting', label: gettext('Default'),
@@ -287,6 +288,7 @@ define('pgadmin.node.schema', [
cellFunction: Backform.cellFunction, editable: function(m) {
return m.handler.get('toast_autovacuum');
},
+ formatter:Backgrid.CellFormatter,
},
{
name: 'setting', label: gettext('Default'),
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals
2021-03-08 16:37 [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Pradip Parkale <[email protected]>
@ 2021-03-09 10:52 ` Pradip Parkale <[email protected]>
2021-03-09 13:19 ` Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Pradip Parkale @ 2021-03-09 10:52 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please ignore my previous email and find the latest attachment. I have
changed the default decimals value from 2 to 5.
On Mon, Mar 8, 2021 at 10:07 PM Pradip Parkale <
[email protected]> wrote:
> Hi Hackers,
>
> Please find attached the patch for RM4784.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/x-patch] RM4784_v2.patch (1.5K, 3-RM4784_v2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
index 03fd7d6e1..740c9fff1 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/static/js/schema.js
@@ -120,7 +120,9 @@ define('pgadmin.node.schema', [
case 'integer':
return Backgrid.IntegerCell;
case 'number':
- return Backgrid.NumberCell;
+ return Backgrid.NumberCell.extend({
+ decimals: this.get('decimals') || Backgrid.NumberFormatter.prototype.defaults.decimals,
+ });
case 'string':
return Backgrid.StringCell;
default:
@@ -210,6 +212,7 @@ define('pgadmin.node.schema', [
{
name: 'value', label: gettext('Value'),
cellHeaderClasses:'width_percent_30',
+ decimals: 5,
cellFunction: Backform.cellFunction, editable: function(m) {
return m.handler.get('autovacuum_custom');
}, headerCell: Backgrid.Extension.CustomHeaderCell,
@@ -284,6 +287,7 @@ define('pgadmin.node.schema', [
name: 'value', label: gettext('Value'),
cellHeaderClasses:'width_percent_30',
headerCell: Backgrid.Extension.CustomHeaderCell,
+ decimals: 5,
cellFunction: Backform.cellFunction, editable: function(m) {
return m.handler.get('toast_autovacuum');
},
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals
2021-03-08 16:37 [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Pradip Parkale <[email protected]>
2021-03-09 10:52 ` Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Pradip Parkale <[email protected]>
@ 2021-03-09 13:19 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2021-03-09 13:19 UTC (permalink / raw)
To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Tue, Mar 9, 2021 at 4:22 PM Pradip Parkale <
[email protected]> wrote:
> Hi Hackers,
>
> Please ignore my previous email and find the latest attachment. I have
> changed the default decimals value from 2 to 5.
>
>
>
> On Mon, Mar 8, 2021 at 10:07 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find attached the patch for RM4784.
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-03-09 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 16:37 [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals Pradip Parkale <[email protected]>
2021-03-09 10:52 ` Pradip Parkale <[email protected]>
2021-03-09 13:19 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox