public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ganesh Jaybhay <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Fix in switch cell tab navigation
Date: Thu, 26 Mar 2020 10:30:22 +0530
Message-ID: <CAK6syAoHoF3iQdd53_acRnx+6b9+MOEK=sq7AbaqeVf5aCKERQ@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELdWQuOJ8pdcPD7FxsZrLf9HnL8Eoiw5-U9GV5goU_nzQQ@mail.gmail.com>
References: <CAK6syAppD_do9JQkdyQA96vsFQys97d5p3D_Ud_eCfvpoCp=Vg@mail.gmail.com>
	<CAFOhELdWQuOJ8pdcPD7FxsZrLf9HnL8Eoiw5-U9GV5goU_nzQQ@mail.gmail.com>

Hi Khushboo,

I have removed the condition added for subgrid-cell. Please find the
attached updated patch

Regards,
Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <
[email protected]> wrote:

> Hi Ganesh,
>
> You have put a check on *subgrid-cell* class, which does not exist in the
> entire source code.
> Also, can you please let me know of any module which you have tested, so I
> can test accordingly though the code for the same looks good to me.
>
> Thanks,
> Khushboo
>
>
> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for below minor fix in the switch cell tab
>> navigation:
>>
>> After pressing the tab key on switch cell, sometimes focus doesn't go to
>> the immediate next editable cell. It goes to the different cell for
>> fraction of seconds and again comes to the next editable cell.
>>
>> Please review.
>>
>> Regards,
>> Ganesh Jaybhay
>>
>


Attachments:

  [application/octet-stream] switch_cell_navigation_v1.patch (1.2K, 3-switch_cell_navigation_v1.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 230d7ce56..b05e1422f 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -717,7 +717,11 @@ define([
           gotoCell = e.shiftKey ? self.$el.prev() : self.$el.next();
         }
 
-        if (gotoCell) {
+        if (gotoCell && gotoCell.length > 0) {
+          if(gotoCell.hasClass('editable')){
+            e.preventDefault();
+            e.stopPropagation();
+          }
           let command = new Backgrid.Command({
             key: 'Tab',
             keyCode: 9,
@@ -727,12 +731,8 @@ define([
           setTimeout(function() {
             // When we have Editable Cell
             if (gotoCell.hasClass('editable') && gotoCell.hasClass('edit-cell')) {
-              e.preventDefault();
-              e.stopPropagation();
               gotoCell.trigger('focus');
             } else if (gotoCell.hasClass('editable')) {
-              e.preventDefault();
-              e.stopPropagation();
               setTimeout(function() {
                 self.model.trigger('backgrid:edited', self.model,
                   self.column, command);

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Fix in switch cell tab navigation
  In-Reply-To: <CAK6syAoHoF3iQdd53_acRnx+6b9+MOEK=sq7AbaqeVf5aCKERQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox