public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][patch] Few UI improvements and fixes
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][patch] Few UI improvements and fixes
@ 2019-01-21 10:59 Ganesh Jaybhay <[email protected]>
2019-01-22 05:53 ` Re: [pgAdmin4][patch] Few UI improvements and fixes Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Ganesh Jaybhay @ 2019-01-21 10:59 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached is the patch for below minor fixes:
1. Proper alignment of help message with date time control
2. Added help-block class for helpMessageClassName
Kindly review.
Regards,
Ganesh Jaybhay
Attachments:
[application/octet-stream] fix_help_message.patch (1.1K, 3-fix_help_message.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index f5783151..5de46af0 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -41,6 +41,7 @@ define([
accordianGroupClassName: 'accordian-group pg-el-12',
accordianContentClassName: 'accordian-content pg-el-12',
hiddenClassName: 'd-none',
+ helpMessageClassName: 'form-text text-muted help-block',
});
Backform.controlMapper = {
@@ -2500,12 +2501,10 @@ define([
' <div class="input-group-append">',
' <span class="input-group-text fa fa-calendar"></span>',
' </div>',
- '</div>',
'<% if (helpMessage && helpMessage.length) { %>',
- ' <div class="<%=Backform.controlsClassName%>">',
' <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
- ' </div>',
'<% } %>',
+ '</div>',
].join('\n')),
render: function() {
var field = _.defaults(this.field.toJSON(), this.defaults),
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin4][patch] Few UI improvements and fixes
2019-01-21 10:59 [pgAdmin4][patch] Few UI improvements and fixes Ganesh Jaybhay <[email protected]>
@ 2019-01-22 05:53 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2019-01-22 05:53 UTC (permalink / raw)
To: Ganesh Jaybhay <[email protected]>; +Cc: pgadmin-hackers
Thanks patch applied.
On Mon, Jan 21, 2019 at 5:05 PM Ganesh Jaybhay <
[email protected]> wrote:
> Hi Hackers,
>
> Attached is the patch for below minor fixes:
> 1. Proper alignment of help message with date time control
> 2. Added help-block class for helpMessageClassName
>
> Kindly review.
>
> Regards,
> Ganesh Jaybhay
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2019-01-22 05:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 10:59 [pgAdmin4][patch] Few UI improvements and fixes Ganesh Jaybhay <[email protected]>
2019-01-22 05:53 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox