public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
Date: Mon, 1 Aug 2016 19:03:55 +0530
Message-ID: <CAKKotZQ+-zCKvohhg0C-n+SE2dX3Y1d+KhHEWudcck86Jrx3Hw@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxBv0QfbjdV2VFLEWWuTYO7YXmFuOwS+1eEXOVCa4rN4A@mail.gmail.com>
References: <CAKKotZR5b=JjkC5cS2x=TzVY2MfEhc+eHpcbMm41eW5jv4uYBA@mail.gmail.com>
	<CA+OCxow2ZO0RRELTnQo45o+mqX6GJpEEHzuZYGg0g6D6msb_9w@mail.gmail.com>
	<CAKKotZQNGSBSa=XjhKfDgBgMpAXEQUaMrBnNkW_F58q2CkdvLQ@mail.gmail.com>
	<CA+OCxoxcKKbHqmhaaOZKQLk1tqTkpereYzN5vCz3zS3oZbUM7A@mail.gmail.com>
	<CAKKotZRH-go6m2uhpVOs9-ps4SiLFvfbjeV5mf9NK+=GztToXw@mail.gmail.com>
	<CA+OCxozYsK_aV5Gwh95-dm4m3HoeS8VS4KwX4Ds7PUXcvmH6eg@mail.gmail.com>
	<CA+OCxowMFzdQm1fQPPAPF3je_-x6oh95XPYX3rW27R0DkYsVFQ@mail.gmail.com>
	<CAKKotZT2YcvNF-cr3XV_EGiWhc-mPvGZCe5r62YFYbx6Zxvhyw@mail.gmail.com>
	<CA+OCxoxf9shrYLa_WyZL5V2FKxV+Mu2UfjCBJCFNv50qyCrJwQ@mail.gmail.com>
	<CAKKotZQmyVg8eJD8+Ha+fNg=MUX_i6YcUJCkJwzp_sWf3mC=uA@mail.gmail.com>
	<CAKKotZQhqoX0FtSCWyuCpW96XsgR7+y3pc60H9VHzEHJCoqRDg@mail.gmail.com>
	<CA+OCxoxBv0QfbjdV2VFLEWWuTYO7YXmFuOwS+1eEXOVCa4rN4A@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

We have to added it because postgres format_type() function do not provide
us type with 'public' schema prefix to it, due to which wrong SQL's are
getting generated.
Rest other types are pre fixed with their respective schema as required.


Thanks,
Murtuza


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Aug 1, 2016 at 6:51 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Thu, Jul 28, 2016 at 10:56 AM, Murtuza Zabuawala
> <[email protected]> wrote:
> > Hi Dave,
> >
> > PFA updated patch to fix issue in functions which was due to improper
> > handing of nested quoting of types in templates.
> > I also fixed it in Table/Column node.
> >
> > Please review.
>
> This doesn't seem right to me:
>
>                 # If schema is not pg_catalog & then add schema
>                 if row['nspname'] != 'pg_catalog' \
>                         and row['nspname'] == 'public':
>                     rtn_type = row['nspname'] + "." + row['typname']
>                 else:
>                     rtn_type = row['typname']
>
> Shouldn't the "and row['nspname'] == 'public'" be removed?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
  In-Reply-To: <CAKKotZQ+-zCKvohhg0C-n+SE2dX3Y1d+KhHEWudcck86Jrx3Hw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox