public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
Date: Mon, 1 Aug 2016 15:24:19 +0100
Message-ID: <CA+OCxozJCntCRBnDY0vyUM86sWeYn5id6SQxZZ=_RS6NhNRrLA@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZT1XntE=3SC+FAoatWR0H3ecyZnQGfv9WY6d4=WbQ3+sw@mail.gmail.com>
References: <CAKKotZR5b=JjkC5cS2x=TzVY2MfEhc+eHpcbMm41eW5jv4uYBA@mail.gmail.com>
<CA+OCxow2ZO0RRELTnQo45o+mqX6GJpEEHzuZYGg0g6D6msb_9w@mail.gmail.com>
<CAKKotZQNGSBSa=XjhKfDgBgMpAXEQUaMrBnNkW_F58q2CkdvLQ@mail.gmail.com>
<CA+OCxoxcKKbHqmhaaOZKQLk1tqTkpereYzN5vCz3zS3oZbUM7A@mail.gmail.com>
<CAKKotZRH-go6m2uhpVOs9-ps4SiLFvfbjeV5mf9NK+=GztToXw@mail.gmail.com>
<CA+OCxozYsK_aV5Gwh95-dm4m3HoeS8VS4KwX4Ds7PUXcvmH6eg@mail.gmail.com>
<CA+OCxowMFzdQm1fQPPAPF3je_-x6oh95XPYX3rW27R0DkYsVFQ@mail.gmail.com>
<CAKKotZT2YcvNF-cr3XV_EGiWhc-mPvGZCe5r62YFYbx6Zxvhyw@mail.gmail.com>
<CA+OCxoxf9shrYLa_WyZL5V2FKxV+Mu2UfjCBJCFNv50qyCrJwQ@mail.gmail.com>
<CAKKotZQmyVg8eJD8+Ha+fNg=MUX_i6YcUJCkJwzp_sWf3mC=uA@mail.gmail.com>
<CAKKotZQhqoX0FtSCWyuCpW96XsgR7+y3pc60H9VHzEHJCoqRDg@mail.gmail.com>
<CA+OCxoxBv0QfbjdV2VFLEWWuTYO7YXmFuOwS+1eEXOVCa4rN4A@mail.gmail.com>
<CAKKotZQ+-zCKvohhg0C-n+SE2dX3Y1d+KhHEWudcck86Jrx3Hw@mail.gmail.com>
<CA+OCxozkMUiTbd5yNNibmm4YBB2Zsyv=594EXj+NUMFgvvX4TQ@mail.gmail.com>
<CAKKotZT1XntE=3SC+FAoatWR0H3ecyZnQGfv9WY6d4=WbQ3+sw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Mon, Aug 1, 2016 at 2:53 PM, Murtuza Zabuawala
<[email protected]> wrote:
> Yes... :-)
OK, committed with the following:
# If schema is public, prefix it. Otherwise, we should
already have it.
if row['nspname'] == 'public':
rtn_type = "public." + row['typname']
else:
rtn_type = row['typname']
> On Mon, Aug 1, 2016 at 7:16 PM, Dave Page <[email protected]> wrote:
>>
>> On Mon, Aug 1, 2016 at 2:33 PM, Murtuza Zabuawala
>> <[email protected]> wrote:
>> > Hi Dave,
>> >
>> > We have to added it because postgres format_type() function do not
>> > provide
>> > us type with 'public' schema prefix to it, due to which wrong SQL's are
>> > getting generated.
>> > Rest other types are pre fixed with their respective schema as required.
>>
>> OK, so:
>>
>> # If schema is not pg_catalog & then add schema
>> if row['nspname'] == 'public':
>> rtn_type = row['nspname'] + "." + row['typname']
>> else:
>> rtn_type = row['typname']
>>
>> ?
>>
>> != pg_catalog is redundant with == public.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (16+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: PATCH: Encoding issue with qtLiteral function (pgAdmin4)
In-Reply-To: <CA+OCxozJCntCRBnDY0vyUM86sWeYn5id6SQxZZ=_RS6NhNRrLA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox