public inbox for [email protected]  
help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RE-SQL tests for Roles & Resource Group nodes
Date: Tue, 2 Jul 2019 12:46:35 +0530
Message-ID: <CAKKotZQiNF7QhQ+GiHHuqLyHLZkF99JS718xiSb9cNooPcwC6Q@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyk3RfY=mDZ_ebb4stY6SgjzHsG5dimY0D=CuvwOtsoLQ@mail.gmail.com>
References: <CAKKotZTXDruJsXhnNCR=uCeWKPkg6DKk1EAEXrUcMFFpaf0CAg@mail.gmail.com>
	<CA+OCxoyk3RfY=mDZ_ebb4stY6SgjzHsG5dimY0D=CuvwOtsoLQ@mail.gmail.com>

Hi Dave,

Please find the updated patch,

- Added a mechanism to check for supported minimum/maximum version and a
server type in the framework.

Please review.


Thanks,
Murtuza

On Mon, Jul 1, 2019 at 7:55 PM Dave Page <[email protected]> wrote:

> Hi
>
> On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA patch to add RE-SQL tests for Roles & Resource Group nodes.
>>
>
> Resource Groups don't exist in PG....
>
> =============Running the test cases for 'Regression - PG 11'=============
> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
> Reverse Engineered SQL Test Cases
>
> Create IMPLICIT Cast
> Alter IMPLICIT Cast
> Drop IMPLICIT Cast
> Create EXPLICIT Cast
> Alter EXPLICIT Cast
> Drop EXPLICIT Cast
>
>
> Create Resource groups
>  ... 2019-07-01 15:24:16,930: ERROR flask.app: Failed to execute query
> (execute_scalar) for the server #2 - DB:postgres (Query-id: 1562639):
> Error Message:ERROR:  syntax error at or near "RESOURCE"
> LINE 1: CREATE RESOURCE GROUP test_resql_resource_group;
>                ^
>
> FAIL
>
> ======================================================================
> FAIL: runTest
> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
> Reverse Engineered SQL Test Cases
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 88, in runTest
>     self.execute_test_case(scenarios)
>   File
> "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.py", line
> 145, in execute_test_case
>     self.assertEquals(response.status_code, 200)
> AssertionError: 500 != 200
>
> ----------------------------------------------------------------------
> Ran 1 test in 0.767s
>
> FAILED (failures=1)
>
> ======================================================================
> Test Result Summary
> ======================================================================
>
> Regression - PG 11:
>
> 0 tests passed
> 1 test failed:
> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
> 0 tests skipped
>
> ======================================================================
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: RE-SQL tests for Roles & Resource Group nodes
  In-Reply-To: <CAKKotZQiNF7QhQ+GiHHuqLyHLZkF99JS718xiSb9cNooPcwC6Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox