Re: RE-SQL tests for Roles & Resource Group nodes

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RE-SQL tests for Roles & Resource Group nodes
Date: Wed, 3 Jul 2019 14:39:30 +0100
Message-ID: <CA+OCxow2Yq_9xFE4cdSoc8R0s_iqLbsWRTSYe=b+Fobu39wN3Q@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZR9_Z-VwvuJs+1EXrWGDV-6sZDA6_81d3gTdRSb9i1ORg@mail.gmail.com>
References: <CAKKotZTXDruJsXhnNCR=uCeWKPkg6DKk1EAEXrUcMFFpaf0CAg@mail.gmail.com>
	<CA+OCxoyk3RfY=mDZ_ebb4stY6SgjzHsG5dimY0D=CuvwOtsoLQ@mail.gmail.com>
	<CAKKotZQiNF7QhQ+GiHHuqLyHLZkF99JS718xiSb9cNooPcwC6Q@mail.gmail.com>
	<CAKKotZRJ+cSMwZQPSRmjocxx-VKcmS7aFUTo18i=ZbGYkCuw=A@mail.gmail.com>
	<CA+OCxoyEVimkOdA4rsFzjagsCseZMbpHCk3Uub_MEuhk4+mM8A@mail.gmail.com>
	<CAKKotZRTCiUD0Y1+Zomiun2-fvEpQKJkkDvcwvhbFNpwV6CSHg@mail.gmail.com>
	<CANxoLDegd4LLkNqBRjkqFEw1EbEMTCYh7MsPvMdAigRy0kL+QA@mail.gmail.com>
	<CA+OCxozKnmF8mg4xXyrymrPNRZTPmacjMfvkvDTvzHGS=0pKqg@mail.gmail.com>
	<CAKKotZR9_Z-VwvuJs+1EXrWGDV-6sZDA6_81d3gTdRSb9i1ORg@mail.gmail.com>

Thanks, applied.

On Wed, Jul 3, 2019 at 2:30 PM Murtuza Zabuawala <
[email protected]> wrote:

> Hi,
>
> PFA updated patch with corrections in the print messages.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
>
> On Wed, Jul 3, 2019 at 5:36 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jul 3, 2019 at 8:35 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Murtuza
>>>
>>> I have tested the patch and I think below string should be modified:
>>> Server(Type: #ppas) is not supported for the Resource Groups module -
>>> Skipped
>>> Server version(120000) is not supported for the Resource Groups module -
>>> Skipped
>>>
>>> It misleads, that server type 'ppas' is not supported for the Resource
>>> Group, it should be changed to "Resource groups are not supported by PG -
>>> Skipped". Similarly for version string should be ''Resource groups are not
>>> supported by PPAS server less/greater than <server version>"
>>>
>>
>> Agreed.
>>
>>
>>>
>>>> Please note that our framework considers test cases from all the
>>>> modules as one single test case, If we need module wise detailed summary
>>>> report for the reverse engineered SQL tests then we may have to change the
>>>> framework.
>>>>
>>>
>> We're just treating all the re-sql tests as one test in the higher-level
>> suite. Maybe we'd want to change that in the future, but I think it's fine
>> for now.
>>
>>
>>>
>>>>
>>>> Regards,
>>>> Murtuza
>>>>
>>>>
>>>> On Tue, Jul 2, 2019 at 5:52 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> ++ Attaching patch
>>>>>>
>>>>>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Please find the updated patch,
>>>>>>>
>>>>>>> - Added a mechanism to check for supported minimum/maximum version
>>>>>>> and a server type in the framework.
>>>>>>>
>>>>>>
>>>>> There's still a problem with this I'm afraid - it says in the summary
>>>>> that the re_sql test cases were all skipped, which is not the case. I think
>>>>> we should just skip the irrelevant tests in the re_sql module, but not mark
>>>>> the entire module as being skipped:
>>>>>
>>>>
>>>>> =============Running the test cases for 'Regression - PG
>>>>> 11'=============
>>>>>
>>>>> runTest
>>>>> (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
>>>>>
>>>>> Reverse Engineered SQL Test Cases
>>>>>
>>>>>
>>>>> Create IMPLICIT Cast
>>>>>
>>>>> Alter IMPLICIT Cast
>>>>>
>>>>> Drop IMPLICIT Cast
>>>>>
>>>>> Create EXPLICIT Cast
>>>>>
>>>>> Alter EXPLICIT Cast
>>>>>
>>>>> Drop EXPLICIT Cast
>>>>>
>>>>>  ... skipped 'Server(Type: #ppas) is not supported for the Resource
>>>>> Groups module'
>>>>>
>>>>>
>>>>> ----------------------------------------------------------------------
>>>>>
>>>>> Ran 1 test in 0.480s
>>>>>
>>>>>
>>>>> OK (skipped=1)
>>>>>
>>>>>
>>>>> ======================================================================
>>>>>
>>>>> Test Result Summary
>>>>>
>>>>> ======================================================================
>>>>>
>>>>>
>>>>> Regression - PG 11:
>>>>>
>>>>>
>>>>> 0 tests passed
>>>>>
>>>>> 0 tests failed
>>>>>
>>>>> 1 test skipped:
>>>>>
>>>>> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
>>>>>
>>>>>
>>>>> ======================================================================
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (11+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: RE-SQL tests for Roles & Resource Group nodes
  In-Reply-To: <CA+OCxow2Yq_9xFE4cdSoc8R0s_iqLbsWRTSYe=b+Fobu39wN3Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox