public inbox for [email protected]  

help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Checklist before sending patch to pgAdmin4-hackers
Date: Wed, 21 Mar 2018 11:31:15 +0530
Message-ID: <CAKKotZQtzxNxmJBVq_=x==p8fwgxx04n=yWdTRZma0MX4qfnRw@mail.gmail.com> (raw)

Hello,

Here is the common checklist to follow before sending patch to
pgAdmin4-hackers group,

1) Get the latest pull from master branch.

2) Apply your patch and check if applies successfully on the latest code.

3) Check for PEP8 issues
- activate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runtests.py

- To run only UI/feature tests
python regression/runtests.py --pkg feature_tests

- To run regression test (without UI/Feature tests)
python regression/runtests.py --exclude feature_tests

5) Run Jasmine tests
- activate virtual env
- cd ../web
yarn run test:karma-once

6) Make sure to add or update help docs and screenshot(s) if you have added
any new feature or changed any existing one.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Checklist before sending patch to pgAdmin4-hackers
  In-Reply-To: <CAKKotZQtzxNxmJBVq_=x==p8fwgxx04n=yWdTRZma0MX4qfnRw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox