public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: Sanket Mehta <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers
Date: Fri, 24 Jun 2016 16:54:30 +0530
Message-ID: <CAKKotZRRWxz2WhJQGonTn4YkPBDS7GYLL3xWM1xfaNFvRGO_HA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow+Vd1P4XgN_XYMVNKiBfj+K5LKPXj31g2Q5k_d+1kj9w@mail.gmail.com>
References: <[email protected]>
<redmine.journal-2631.20160613094255.50340dcbfb33bf96@postgresql.org>
<CA+yw=mMMC-e5eTAd0zdQOPhberf+-2N7GBAPnEQ18ifH24EiAg@mail.gmail.com>
<CA+OCxow+Vd1P4XgN_XYMVNKiBfj+K5LKPXj31g2Q5k_d+1kj9w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi,
PFA patch to fix the issue RM#1292.
Earlier patch was not handling spaces properly.
e.g- If user creates any objects which has spaces in its name then it fails
to parse it next time user select it.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Jun 20, 2016 at 8:34 PM, Dave Page <[email protected]> wrote:
> Thanks, patch applied.
>
> On Mon, Jun 20, 2016 at 2:56 PM, Sanket Mehta
> <[email protected]> wrote:
> > Hi,
> >
> > PFA the revised patch to resolve this issue which consists the change in
> > control formatter.
> >
> >
> > Regards,
> > Sanket Mehta
> > Sr Software engineer
> > Enterprisedb
> >
> > On Mon, Jun 13, 2016 at 3:12 PM, <[email protected]> wrote:
> >>
> >> Issue #1292 has been updated by Dave Page.
> >>
> >> Target version deleted (1.0 Beta 1)
> >>
> >> ________________________________
> >>
> >> Bug #1292: ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.,"
> does
> >> not exist message throws if template database contain special charterers
> >>
> >> Author: Fahar Abbas
> >> Status: In Progress
> >> Priority: Normal
> >> Assignee: Sanket Mehta
> >> Category:
> >> Target version:
> >>
> >> Commit ID:
> >> -----------
> >> commit 954163b4957c1dce89c0632d009b845cbe90faf4
> >>
> >> Browser version:
> >> ----------------
> >> Firefox 45.0.2
> >>
> >> Python version:
> >> ----------------
> >> 3.5.1+
> >>
> >> Platforms:
> >> All
> >>
> >> ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not
> exist
> >> message throws if user try to create database with template database
> that
> >> name contain special charterers.
> >>
> >> Please note that this issue is not reproducible in other template
> >> databases that name is simple one.
> >>
> >> Please note that this is not reproduce in pgAdmin3.
> >>
> >> Steps:
> >>
> >> 1. Install pgAdmin4 on Ubuntu 16.04
> >> 2. Install PG-9.6-beta 1 installer
> >> 3. Expand database node
> >> 4. give it's name !#$%^&*()_+{}|:"<>?=-\][';/.,
> >> 5. Database created successfully
> >> 6. Again create new database and give it's name abcd
> >> 7. Click on definition tab
> >> 8. select template database !#$%^&*()_+{}|:"<>?=-\][';/.,
> >> 9. Click on Save button
> >>
> >> Files Screen Shot 2016-06-02 at 10.25.34 am.png (1020 KB)
> >> Screen Shot 2016-06-02 at 10.26.01 am.png (1.03 MB)
> >> ________________________________
> >>
> >> You have received this notification because you have either subscribed
> to
> >> it, or are involved in it.
> >> To change your notification preferences, please click here:
> >> https://redmine.postgresql.org/my/account
> >
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list ([email protected])
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] RM_1292.patch (624B, 3-RM_1292.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 7431765..1370698 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1787,10 +1787,10 @@
var Select2Formatter = function() {};
_.extend(Select2Formatter.prototype, {
fromRaw: function(rawData, model) {
- return JSON.parse(JSON.stringify(_.escape(rawData)));
+ return encodeURIComponent(rawData);
},
toRaw: function(formattedData, model) {
- return formattedData;
+ return decodeURIComponent(formattedData);
}
});
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Re: [pgAdmin 4 - Bug #1292] ERROR: template database "!@#$%^&*()_+{}|:"<>?=-\\][';/.," does not exist message throws if template database contain special charterers
In-Reply-To: <CAKKotZRRWxz2WhJQGonTn4YkPBDS7GYLL3xWM1xfaNFvRGO_HA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox